Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 229003004: Xfermode: SSE2 implementation of hardlight mode (Closed)

Created:
6 years, 8 months ago by qiankun
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Xfermode: SSE2 implementation of hardlight mode With SSE2 optimization, performance of Xfermode_HardLight will improve about 45% on desktop i7-3770. Here are the data: before: Xfermode_HardLight 8888: cmsecs = 48.43 565: cmsecs = 63.11 after: Xfermode_HardLight 8888: cmsecs = 25.71 565: cmsecs = 33.46 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14373

Patch Set 1 #

Patch Set 2 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M src/opts/SkXfermode_opts_SSE2.cpp View 1 2 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
qiankun
PTAL.
6 years, 8 months ago (2014-04-11 08:13:41 UTC) #1
mtklein
lgtm
6 years, 8 months ago (2014-04-24 17:25:40 UTC) #2
qiankun
The CQ bit was checked by qiankun.miao@intel.com
6 years, 8 months ago (2014-04-25 05:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/229003004/20001
6 years, 8 months ago (2014-04-25 05:07:09 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 05:23:53 UTC) #5
Message was sent while issue was closed.
Change committed as 14373

Powered by Google App Engine
This is Rietveld 408576698