Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2290023002: test262 roll (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

This patch updates to the latest test262 version A number of known failures are marked. To support test262's new tests which simulate multiple script tags, this patch calls out to the d8 realm API from the harness adaptation code. Committed: https://crrev.com/af1d06a9bc8c6f54e91f64c4c8ec207dbc95a451 Cr-Commit-Position: refs/heads/master@{#39099}

Patch Set 1 #

Patch Set 2 : evalScript in d8 #

Patch Set 3 : more failures #

Patch Set 4 : let evalScript throw its original error #

Patch Set 5 : Clean up d8; mark all failures #

Patch Set 6 : format #

Patch Set 7 : disable another test #

Patch Set 8 : Remove d8 changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -44 lines) Patch
M DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M test/test262/detachArrayBuffer.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262/harness-adapt.js View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 3 4 5 6 6 chunks +99 lines, -43 lines 0 comments Download

Messages

Total messages: 30 (22 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-08-31 22:59:41 UTC) #13
Dan Ehrenberg
The new version removes the changes to d8, PTAL.
4 years, 3 months ago (2016-08-31 23:55:41 UTC) #20
adamk
lgtm
4 years, 3 months ago (2016-09-01 17:10:35 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290023002/140001
4 years, 3 months ago (2016-09-01 17:40:51 UTC) #25
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 3 months ago (2016-09-01 17:42:32 UTC) #26
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/af1d06a9bc8c6f54e91f64c4c8ec207dbc95a451 Cr-Commit-Position: refs/heads/master@{#39099}
4 years, 3 months ago (2016-09-01 17:43:42 UTC) #28
Michael Achenbach
Please note this breakage: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/9450
4 years, 3 months ago (2016-09-01 20:10:26 UTC) #29
adamk
4 years, 3 months ago (2016-09-01 20:12:39 UTC) #30
Message was sent while issue was closed.
On 2016/09/01 20:10:26, machenbach (slow) wrote:
> Please note this breakage:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2...

Fixed in https://codereview.chromium.org/2305793002/

Powered by Google App Engine
This is Rietveld 408576698