cc: Set the mapped memory reclaim limit for the renderer compositor on Android

cc/resources/pixel_buffer_raster_worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/pixel_buffer_raster_worker_pool.h"
 
+#include <limits>
+
 #include "base/containers/stack_container.h"
 #include "base/debug/trace_event.h"
 #include "base/values.h"
 #include "cc/debug/traced_value.h"
 #include "cc/resources/resource.h"
 #include "third_party/skia/include/core/SkBitmapDevice.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/sys_utils.h"
 #endif
@@ skipping 70 matching lines @@
 
 // Only used as std::find_if predicate for DCHECKs.
 bool WasCanceled(const internal::RasterWorkerPoolTask* task) {
   return task->WasCanceled();
 }
 
 }  // namespace
 
 PixelBufferRasterWorkerPool::PixelBufferRasterWorkerPool(
     ResourceProvider* resource_provider,
-    size_t num_threads)
+    size_t num_threads,
+    ContextProvider* context_provider)
     : RasterWorkerPool(resource_provider, num_threads),
       shutdown_(false),
       scheduled_raster_task_count_(0),
       bytes_pending_upload_(0),
       has_performed_uploads_since_last_flush_(false),
       check_for_completed_raster_tasks_pending_(false),
       should_notify_client_if_no_tasks_are_pending_(false),
       should_notify_client_if_no_tasks_required_for_activation_are_pending_(
           false) {
-// If we raster too fast we become upload bound, and pending
-// uploads consume memory. For maximum upload throughput, we would
-// want to allow for upload_throughput * pipeline_time of pending
-// uploads, after which we are just wasting memory. Since we don't
-// know our upload throughput yet, this just caps our memory usage.
-#if defined(OS_ANDROID)
-  size_t divider = 1;
-  if (base::android::SysUtils::IsLowEndDevice())
-    divider = 3;
-
-  // For reference Nexus10 can upload 1MB in about 2.5ms.
-  const size_t kMaxBytesUploadedPerMs = (2 * 1024 * 1024) / (5 * divider);
-#else
-  // For reference Chromebook Pixel can upload 1MB in about 0.5ms.
-  const size_t kMaxBytesUploadedPerMs = 1024 * 1024 * 2;
-#endif
-
-  // Assuming a two frame deep pipeline.
-  max_bytes_pending_upload_ = 16 * 2 * kMaxBytesUploadedPerMs;
+  if (context_provider != NULL) {
+    max_bytes_pending_upload_ =
+        context_provider->ContextCapabilities().max_transfer_buffer_usage_bytes;
+  } else {
+    // For unit tests:

[danakj, 2013/08/29 20:10:28]

// Software compositing should not use this path in production. Just use a
default value when testing this path with software compositor.

[danakj, 2013/08/29 20:10:28]

reveman@ can we #if !defined(UNIT_TEST) => NOT_REACHED(); ?

If not, can we TODO() to do that?

[kaanb, 2013/08/30 01:11:35]

Done.

+    // TODO(kaanb): make this a static const somewhere?

[danakj, 2013/08/29 20:10:28]

No idea where. If reveman@ has an idea let's do that, otherwise I think just
drop the TODO.

[kaanb, 2013/08/30 01:11:35]

Done.

+    max_bytes_pending_upload_ = std::numeric_limits<size_t>::max();
+  }
 }
 
 PixelBufferRasterWorkerPool::~PixelBufferRasterWorkerPool() {
   DCHECK(shutdown_);
   DCHECK(!check_for_completed_raster_tasks_pending_);
   DCHECK_EQ(0u, pixel_buffer_tasks_.size());
   DCHECK_EQ(0u, tasks_with_pending_upload_.size());
   DCHECK_EQ(0u, completed_tasks_.size());
 }
 
@@ skipping 554 matching lines @@
 
   throttle_state->SetInteger("bytes_available_for_upload",
                              max_bytes_pending_upload_ - bytes_pending_upload_);
   throttle_state->SetInteger("bytes_pending_upload", bytes_pending_upload_);
   throttle_state->SetInteger("scheduled_raster_task_count",
                              scheduled_raster_task_count_);
   return throttle_state.PassAs<base::Value>();
 }
 
 }  // namespace cc