cc/test/impl_side_painting_settings.h - Issue 22900018: cc: Set the mapped memory reclaim limit for the renderer compositor on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/test/impl_side_painting_settings.h

Issue 22900018: cc: Set the mapped memory reclaim limit for the renderer compositor on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/max_bytes_pending_upload/max_transfer_buffer_usage_bytes/ Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_TEST_IMPL_SIDE_PAINTING_SETTINGS_H_	5 #ifndef CC_TEST_IMPL_SIDE_PAINTING_SETTINGS_H_

6 #define CC_TEST_IMPL_SIDE_PAINTING_SETTINGS_H_	6 #define CC_TEST_IMPL_SIDE_PAINTING_SETTINGS_H_

7	7

	8 #include <limits>

	9

8 #include "cc/trees/layer_tree_settings.h"	10 #include "cc/trees/layer_tree_settings.h"

9	11

10 namespace cc {	12 namespace cc {

11	13

12 class ImplSidePaintingSettings : public LayerTreeSettings {	14 class ImplSidePaintingSettings : public LayerTreeSettings {

13 public:	15 public:

14 ImplSidePaintingSettings() {	16 ImplSidePaintingSettings() {

15 impl_side_painting = true;	17 impl_side_painting = true;

	18 max_transfer_buffer_usage_bytes = std::numeric_limits<size_t>::max();
	danakj 2013/08/23 01:21:46 needed? this is awkward cuz this class should just needed? this is awkward cuz this class should just turn on impl paint really. can this move out to the places that use this class if needed? kaanb 2013/08/23 01:37:31 https://code.google.com/p/chromium/codesearch#chro Show quoted text On 2013/08/23 01:21:46, danakj wrote: > needed? this is awkward cuz this class should just turn on impl paint really. > can this move out to the places that use this class if needed? https://code.google.com/p/chromium/codesearch#chromium/src/cc/layers/picture_... It's used here and if I don't set the max_transfer_buffer_usage_bytes the test fails with the DCHECK that checks for max_transfer_buffer_usage_bytes not being 0 in PBRWP
16 }	19 }

17 };	20 };

18	21

19 } // namespace cc	22 } // namespace cc

20	23

21 #endif // CC_TEST_IMPL_SIDE_PAINTING_SETTINGS_H_	24 #endif // CC_TEST_IMPL_SIDE_PAINTING_SETTINGS_H_

OLD	NEW

« no previous file with comments | « cc/resources/tile_manager.cc ('k') | cc/test/layer_tree_test.cc » ('j') | cc/test/layer_tree_test.cc » ('J')