Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2289983002: Remove PPAPI gyp files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
bbudge, bradnelson
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PPAPI gyp files. Inlines the sources from ppapi_sources.gypi into the respective BUILD.gn files. Previously the cpp sources were compiled into two targets, one in //ppapi:ppapi_cpp_sources (referenced only from nacl), and one in //ppapi/cpp (referenced only from trusted). This patch merges them into the cpp directory, which now morphs as required for the build type. R=bbudge TBR=bradnelson (chrome/test/data/nacl) Committed: https://crrev.com/9d6a868b4d36d349aedd875a799a47d296776f84 Cr-Commit-Position: refs/heads/master@{#415183}

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : fixes #

Patch Set 4 : visibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -4366 lines) Patch
M chrome/test/data/nacl/BUILD.gn View 9 chunks +9 lines, -9 lines 0 comments Download
M ppapi/BUILD.gn View 5 chunks +208 lines, -58 lines 0 comments Download
M ppapi/c/BUILD.gn View 1 chunk +140 lines, -3 lines 0 comments Download
M ppapi/cpp/BUILD.gn View 1 2 3 2 chunks +283 lines, -3 lines 0 comments Download
D ppapi/native_client/native_client.gyp View 1 chunk +0 lines, -319 lines 0 comments Download
D ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp View 1 chunk +0 lines, -96 lines 0 comments Download
D ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 1 chunk +0 lines, -180 lines 0 comments Download
D ppapi/ppapi.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D ppapi/ppapi_cpp.gypi View 1 chunk +0 lines, -69 lines 0 comments Download
D ppapi/ppapi_gl.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D ppapi/ppapi_host.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D ppapi/ppapi_internal.gyp View 1 chunk +0 lines, -278 lines 0 comments Download
D ppapi/ppapi_ipc.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D ppapi/ppapi_ipc_nacl.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D ppapi/ppapi_nacl.gyp View 1 chunk +0 lines, -402 lines 0 comments Download
D ppapi/ppapi_nacl_test_common.gypi View 1 chunk +0 lines, -285 lines 0 comments Download
D ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -310 lines 0 comments Download
D ppapi/ppapi_proxy_nacl.gyp View 1 chunk +0 lines, -57 lines 0 comments Download
D ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -365 lines 0 comments Download
D ppapi/ppapi_shared_nacl.gyp View 1 chunk +0 lines, -47 lines 0 comments Download
D ppapi/ppapi_sources.gni View 1 chunk +0 lines, -11 lines 0 comments Download
D ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -578 lines 0 comments Download
D ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -706 lines 0 comments Download
M ppapi/tests/extensions/BUILD.gn View 8 chunks +8 lines, -8 lines 0 comments Download
D ppapi/tests/extensions/extensions.gyp View 1 chunk +0 lines, -327 lines 0 comments Download
D ppapi/tools/ppapi_tools.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/liblouis/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
brettw
4 years, 3 months ago (2016-08-29 21:23:52 UTC) #2
bbudge
LGTM (woohoo!)
4 years, 3 months ago (2016-08-29 21:55:04 UTC) #4
brettw
fixes
4 years, 3 months ago (2016-08-29 22:10:29 UTC) #6
brettw
visibility
4 years, 3 months ago (2016-08-29 22:56:49 UTC) #10
brettw
TBR bradnelson for chrome/test/data/nacl. Can we delete or update the OWNERS file for this directory? ...
4 years, 3 months ago (2016-08-30 00:10:17 UTC) #16
bradnelson
lgtm
4 years, 3 months ago (2016-08-30 00:36:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289983002/60001
4 years, 3 months ago (2016-08-30 02:11:04 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 05:52:23 UTC) #22
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9d6a868b4d36d349aedd875a799a47d296776f84 Cr-Commit-Position: refs/heads/master@{#415183}
4 years, 3 months ago (2016-08-30 05:54:41 UTC) #24
Mark Seaborn
4 years, 3 months ago (2016-09-01 22:45:22 UTC) #25
Message was sent while issue was closed.
FYI, this appears to break the linux_nacl_sdk_build trybot, which stops the
automated NaCl DEPS rolls from succeeding.

This roll failed just now: https://codereview.chromium.org/2303543004/

The failure was:
Updating projects from gyp files...
gyp:
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp
not found (cwd: /b/build/slave/linux_nacl_sdk_build/build/src)

-- from here:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_nacl_sdk...

Powered by Google App Engine
This is Rietveld 408576698