Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2289963002: build: Fix getting available memory on mac (Closed)

Created:
4 years, 3 months ago by boliu
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Fix getting available memory on mac BUG=641343 Committed: https://crrev.com/33c0e58a137303fad853488fa0192a58b0ca72a1 Cr-Commit-Position: refs/heads/master@{#415205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/get_concurrent_links.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
boliu
ptal
4 years, 3 months ago (2016-08-29 20:08:27 UTC) #2
scottmg
lgtm
4 years, 3 months ago (2016-08-29 20:15:56 UTC) #5
brucedawson
Sorry for failing to notice the bug on the previous CL. lgtm.
4 years, 3 months ago (2016-08-29 20:34:04 UTC) #9
Dirk Pranke
lgtm also. We all failed to notice it :(.
4 years, 3 months ago (2016-08-29 20:49:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289963002/1
4 years, 3 months ago (2016-08-29 20:56:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:12:05 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:15:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33c0e58a137303fad853488fa0192a58b0ca72a1
Cr-Commit-Position: refs/heads/master@{#415205}

Powered by Google App Engine
This is Rietveld 408576698