Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2289883002: Add docs for GN/Android (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add docs for GN/Android While I'm at it, add a few more examples of other types of builds you can do. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289883002 NOTRY=true DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2289883002 Committed: https://skia.googlesource.com/skia/+/adbd480102ff0f1d7f85b09e3d87c713f2442dd2

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : more examples #

Patch Set 4 : rest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M site/user/quick/gn.md View 1 2 3 2 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mtklein_C
4 years, 3 months ago (2016-08-29 17:17:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289883002/60001
4 years, 3 months ago (2016-08-29 17:18:24 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-29 17:18:25 UTC) #8
jcgregorio
lgtm
4 years, 3 months ago (2016-08-29 17:24:59 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 17:27:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/adbd480102ff0f1d7f85b09e3d87c713f2442dd2

Powered by Google App Engine
This is Rietveld 408576698