third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-composited-sibling.html - Issue 2289833002: Disable clipping on root scroller's ancestors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-composited-sibling.html

Issue 2289833002: Disable clipping on root scroller's ancestors. (Closed)

Patch Set: Undo changes to REF and moved comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-composited-sibling-expected.png » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 ::-webkit-scrollbar {

	4 width: 0px;

	5 height: 0px;

	6 }

	7

	8 body, html {

	9 width: 100%;

	10 height: 100%;

	11 background-color: blue;

	12 }

	13

	14 body {

	15 margin: 0px;

	16 }

	17

	18 iframe {

	19 width: 100vw;

	20 height: 100vh;

	21 left: -50px;

	22 top: -50px;

	23 position: absolute;

	24 border: 0;

	25 }

	26

	27 .clipBox {

	28 position: absolute;

	29 overflow: hidden;

	30 left: 50px;

	31 right: 50px;

	32 top: 50px;

	33 bottom: 50px;

	34 transform: translateZ(0);

	35 }

	36 </style>

	37

	38 <script>

	39 // This test passed if the output is a fully yellow screen. We expect that

	40 // the "clipBox" boxes in this document and the iframe will have their

	41 // clipping layers disabled/removed since the child #container element in the

	42 // iframe is made to be the root scroller.

	43 if (window.testRunner)

	44 testRunner.dumpAsTextWithPixelResults();
	bokan 2016/09/09 00:19:03 Do you know of a way to dump _just_ the pixel resu Do you know of a way to dump _just_ the pixel results? Having empty .txt files seems like a drag. chrishtr 2016/09/09 18:21:15 I don't know of a way. Agree it's weird. Show quoted text On 2016/09/09 at 00:19:03, bokan wrote: > Do you know of a way to dump _just_ the pixel results? Having empty .txt files seems like a drag. I don't know of a way. Agree it's weird.
	45

	46 window.addEventListener('load', function() {

	47 document.rootScroller = document.getElementById('child');

	48 });

	49 </script>

	50

	51 <div class="clipBox">

	52 <iframe id="child" src="resources/clipping-ancestor-is-composited-sibling-if rame.html"></iframe>
	chrishtr 2016/09/09 18:21:15 Why do all your tests uses iframes? Why do all your tests uses iframes? bokan 2016/09/10 00:05:54 Iframes are probably the more important case for t Show quoted text On 2016/09/09 18:21:15, chrishtr wrote: > Why do all your tests uses iframes? Iframes are probably the more important case for this feature (AMP specifically mentioned it's only useful via iframes) so I want to make sure that's well tested. I've also added some basic non-iframe tests now too.
	53 </div>

OLD	NEW