Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: components/domain_reliability/google_configs_unittest.cc

Issue 2289763003: Remove stl_util use from domain_reliability. (Closed)
Patch Set: win Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/google_configs_unittest.cc
diff --git a/components/domain_reliability/google_configs_unittest.cc b/components/domain_reliability/google_configs_unittest.cc
index 8dfd3b0d0fd6160f2a94ceece1a933a892d37a10..fbe3aecdb2afbb494d535c2a9c550439131906b2 100644
--- a/components/domain_reliability/google_configs_unittest.cc
+++ b/components/domain_reliability/google_configs_unittest.cc
@@ -4,28 +4,26 @@
#include "components/domain_reliability/google_configs.h"
-#include "base/stl_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace domain_reliability {
namespace {
-typedef std::vector<DomainReliabilityConfig*> ConfigPointerVector;
+using ConfigPointerVector =
+ std::vector<std::unique_ptr<DomainReliabilityConfig>>;
TEST(DomainReliabilityGoogleConfigsTest, Enumerate) {
ConfigPointerVector configs;
- base::STLElementDeleter<ConfigPointerVector> configs_deleter(&configs);
GetAllGoogleConfigs(&configs);
}
TEST(DomainReliabilityGoogleConfigsTest, ConfigsAreValid) {
ConfigPointerVector configs;
- base::STLElementDeleter<ConfigPointerVector> configs_deleter(&configs);
GetAllGoogleConfigs(&configs);
- for (auto* config : configs)
+ for (auto& config : configs)
EXPECT_TRUE(config->IsValid());
}

Powered by Google App Engine
This is Rietveld 408576698