Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2289723002: PlzNavigate: update LayoutTest filter (Closed)

Created:
4 years, 3 months ago by arthursonzogni
Modified:
4 years, 3 months ago
Reviewers:
clamy
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: update LayoutTest filter Every Navigation Timing's bugs were already solved, but there was still unrelated bugs in this category. - The test: http/tests/misc/timer-vs-loading was misclassified in 'Navigation Timing'. It is now in 'untriaged navigation'. - The other ones, classified in 'Navigation Timing', have been moved in 'Resource Timing'(BUG 641912) BUG=576261 Committed: https://crrev.com/c7f4868af47b526b559eb1d045ae3732dc91a6b3 Cr-Commit-Position: refs/heads/master@{#415257}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
arthursonzogni
Hi Camille! Could you review this CL? Thanks!
4 years, 3 months ago (2016-08-29 11:47:21 UTC) #2
clamy
Thanks! Lgtm
4 years, 3 months ago (2016-08-29 17:37:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289723002/1
4 years, 3 months ago (2016-08-30 07:40:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/60552)
4 years, 3 months ago (2016-08-30 07:43:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289723002/20001
4 years, 3 months ago (2016-08-30 08:27:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 09:40:09 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:43:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7f4868af47b526b559eb1d045ae3732dc91a6b3
Cr-Commit-Position: refs/heads/master@{#415257}

Powered by Google App Engine
This is Rietveld 408576698