Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More functions to follow.

BUG=642653
Committed: https://crrev.com/568a4685b88645b473a9f132365000f37f7b1940
Cr-Commit-Position: refs/heads/master@{#416244}

[Prashant.Patil, 2016-08-29 11:05:13]

Description was changed from

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

R=dpranke@chromium.org
BUG=
==========

to

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.
==========

[Prashant.Patil, 2016-08-29 11:05:13]

prashant.patil@imgtec.com changed reviewers:
+ gordana.cmiljanovic@imgtec.com, raghu.gandham@imgtec.com

[Stephen Chennney, 2016-08-29 15:42:04]

schenney@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org
- dpranke@chromium.org, gordana.cmiljanovic@imgtec.com, raghu.gandham@imgtec.com

[Stephen Chennney, 2016-08-29 15:45:05]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-08-29 15:45:05]

Are the new macros in preparation for more code that uses them?

[Dirk Pranke, 2016-08-29 15:54:33]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-29 15:54:33]

GN/GYP changes lgtm.

[Ken Russell (switch to Gerrit), 2016-08-29 22:13:49]

The code changes look fine, but could you please file a Chromium issue about
this and reference it (via "BUG=") in your CL description? Thanks.

Do you have any performance measurements of this change?

[Prashant.Patil, 2016-08-30 04:50:29]

On 2016/08/29 15:45:05, Stephen Chennney wrote:
> Are the new macros in preparation for more code that uses them?

Yes..it will be used/updated further as we keep adding more MSA optimized
functions.

[Prashant.Patil, 2016-08-30 08:33:50]

On 2016/08/29 22:13:49, Ken Russell wrote:
> The code changes look fine, but could you please file a Chromium issue about
> this and reference it (via "BUG=") in your CL description? Thanks.
> 
> Do you have any performance measurements of this change?

Sorry, I couldn't get what you meant by "file a Chromium issue about this and
reference it (via "BUG=")"?
Do you want me to create a new issue? If Yes, then not getting the need of it.

The performance improvements for function unpackOneRowOfRGBA5551ToRGBA8MSA() is
~3.5x

Thanks

[Ken Russell (switch to Gerrit), 2016-08-30 13:36:22]

On 2016/08/30 08:33:50, Prashant.Patil wrote:
> On 2016/08/29 22:13:49, Ken Russell wrote:
> > The code changes look fine, but could you please file a Chromium issue about
> > this and reference it (via "BUG=") in your CL description? Thanks.
> > 
> > Do you have any performance measurements of this change?
> 
> Sorry, I couldn't get what you meant by "file a Chromium issue about this and
> reference it (via "BUG=")"?
> Do you want me to create a new issue?

Yes, please.

> If Yes, then not getting the need of it.

Since you plan to do more ports of these functions, they should all reference
the same bug ID, so there is a single place to refer back to that lists all of
the associated CLs.

> The performance improvements for function unpackOneRowOfRGBA5551ToRGBA8MSA()
is
> ~3.5x

That's great. For which test? A micro-benchmark or something that actually loads
lots of images and uploads them to textures?

> Thanks

Thank you for this contribution.

[Prashant.Patil, 2016-08-31 08:14:20]

Description was changed from

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.
==========

to

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.

BUG=642653
==========

[Prashant.Patil, 2016-08-31 08:36:55]

On 2016/08/30 13:36:22, Ken Russell wrote:
> On 2016/08/30 08:33:50, Prashant.Patil wrote:
> > On 2016/08/29 22:13:49, Ken Russell wrote:
> > > The code changes look fine, but could you please file a Chromium issue
about
> > > this and reference it (via "BUG=") in your CL description? Thanks.
> > > 
> > > Do you have any performance measurements of this change?
> > 
> > Sorry, I couldn't get what you meant by "file a Chromium issue about this
and
> > reference it (via "BUG=")"?
> > Do you want me to create a new issue?
> 
> Yes, please.
> 
> > If Yes, then not getting the need of it.
> 
> Since you plan to do more ports of these functions, they should all reference
> the same bug ID, so there is a single place to refer back to that lists all of
> the associated CLs.
> 
> > The performance improvements for function unpackOneRowOfRGBA5551ToRGBA8MSA()
> is
> > ~3.5x
> 
> That's great. For which test? A micro-benchmark or something that actually
loads
> lots of images and uploads them to textures?
> 
> > Thanks
> 
> Thank you for this contribution.


Created new issue and added it as BUG=642653
The optimized function comes under blink_platform_unittests.

[Ken Russell (switch to Gerrit), 2016-08-31 18:58:45]

Thank you. LGTM

[Prashant.Patil, 2016-09-01 04:49:42]

The CQ bit was checked by prashant.patil@imgtec.com

[Prashant.Patil, 2016-09-01 04:49:52]

The CQ bit was unchecked by prashant.patil@imgtec.com

[commit-bot: I haz the power, 2016-09-01 04:49:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Prashant.Patil, 2016-09-01 04:50:08]

The CQ bit was checked by prashant.patil@imgtec.com

[commit-bot: I haz the power, 2016-09-01 04:50:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 06:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 06:45:52]

Failed to apply patch for
third_party/WebKit/Source/platform/blink_platform.gypi:
While running git apply --index -3 -p1;
  error: third_party/WebKit/Source/platform/blink_platform.gypi: does not exist
in index

Patch:       third_party/WebKit/Source/platform/blink_platform.gypi
Index: third_party/WebKit/Source/platform/blink_platform.gypi
diff --git a/third_party/WebKit/Source/platform/blink_platform.gypi
b/third_party/WebKit/Source/platform/blink_platform.gypi
index
818a85de811cbf9bb73770b736d2815c0e895097..0cc1810dbe4a66ba333c6bba7c624ea7015e50e2
100644
--- a/third_party/WebKit/Source/platform/blink_platform.gypi
+++ b/third_party/WebKit/Source/platform/blink_platform.gypi
@@ -287,6 +287,7 @@
       'clipboard/ClipboardUtilities.h',
       'clipboard/ClipboardUtilitiesPosix.cpp',
       'clipboard/ClipboardUtilitiesWin.cpp',
+      'cpu/mips/CommonMacrosMSA.h',
       'credentialmanager/PlatformCredential.cpp',
       'credentialmanager/PlatformCredential.h',
       'credentialmanager/PlatformFederatedCredential.cpp',
@@ -684,6 +685,7 @@
       'graphics/compositing/PaintArtifactCompositor.cpp',
       'graphics/compositing/PaintArtifactCompositor.h',
       'graphics/cpu/arm/WebGLImageConversionNEON.h',
+      'graphics/cpu/mips/WebGLImageConversionMSA.h',
       'graphics/cpu/x86/WebGLImageConversionSSE.h',
       'graphics/filters/DistantLightSource.cpp',
       'graphics/filters/DistantLightSource.h',

[Prashant.Patil, 2016-09-01 09:28:40]

The CQ bit was checked by prashant.patil@imgtec.com

[Prashant.Patil, 2016-09-01 09:28:41]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2289693002/#ps20001
(title: "Fixed merge conflicts in blink_platform.gypi")

[commit-bot: I haz the power, 2016-09-01 09:28:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 09:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 09:30:48]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Prashant.Patil, 2016-09-01 09:47:35]

The CQ bit was checked by prashant.patil@imgtec.com

[Prashant.Patil, 2016-09-01 09:47:35]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2289693002/#ps40001
(title: "Brought forward patch set 1 files")

[commit-bot: I haz the power, 2016-09-01 09:47:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 09:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 09:49:48]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Prashant.Patil, 2016-09-01 11:31:40]

The CQ bit was checked by prashant.patil@imgtec.com

[commit-bot: I haz the power, 2016-09-01 11:32:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 11:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 11:33:56]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Prashant.Patil, 2016-09-02 04:40:47]

The CQ bit was checked by prashant.patil@imgtec.com

[commit-bot: I haz the power, 2016-09-02 04:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 04:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 04:42:54]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Prashant.Patil, 2016-09-02 08:14:41]

On 2016/09/02 04:42:54, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Fixed merge issues

[Prashant.Patil, 2016-09-02 08:14:56]

The CQ bit was checked by prashant.patil@imgtec.com

[Prashant.Patil, 2016-09-02 08:14:56]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2289693002/#ps60001
(title: "Fixed merge conflicts")

[commit-bot: I haz the power, 2016-09-02 08:15:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 12:24:27]

Description was changed from

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.

BUG=642653
==========

to

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.

BUG=642653
==========

[commit-bot: I haz the power, 2016-09-02 12:24:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 12:26:10]

Description was changed from

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.

BUG=642653
==========

to

==========
Add MIPS SIMD Arch (MSA) optimized WebGL image conversion function

Added first MSA optimized function of WebGL image conversion module. More
functions to follow.

BUG=642653

Committed: https://crrev.com/568a4685b88645b473a9f132365000f37f7b1940
Cr-Commit-Position: refs/heads/master@{#416244}
==========

[commit-bot: I haz the power, 2016-09-02 12:26:12]

Patchset 4 (id:??) landed as
https://crrev.com/568a4685b88645b473a9f132365000f37f7b1940
Cr-Commit-Position: refs/heads/master@{#416244}