Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2289683002: [heap] Change LO space limit to 512k - page header (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Change LO space limit to 512k - page header BUG=chromium:636331 R=ulan@chromium.org Committed: https://crrev.com/3b8ad45e0f3006dd4351d96b95427453df2bf619 Cr-Commit-Position: refs/heads/master@{#39106}

Patch Set 1 #

Patch Set 2 : Add missing test change from previous CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/heap/spaces.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Michael Lippautz
4 years, 3 months ago (2016-09-01 15:09:13 UTC) #3
ulan
lgtm
4 years, 3 months ago (2016-09-01 15:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289683002/1
4 years, 3 months ago (2016-09-01 18:04:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/3442) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-01 18:19:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289683002/20001
4 years, 3 months ago (2016-09-01 19:03:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 20:09:52 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:11:02 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b8ad45e0f3006dd4351d96b95427453df2bf619
Cr-Commit-Position: refs/heads/master@{#39106}

Powered by Google App Engine
This is Rietveld 408576698