Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2289673003: a11y: use decoration tooltip for location bar decoration view a11y title (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

a11y: use decoration tooltip for location bar decoration view a11y title Use the underlying LocationBarDecoration's tooltip for DecorationAccessibilityView's accessibility title. Before: Star icon read by VO as "button, button" After: Star icon read by VO as "Bookmark this page, button" BUG=613019 Committed: https://crrev.com/32f65a0c6b303fe3619bb33ac62f687ab4eb2553 Cr-Commit-Position: refs/heads/master@{#415012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
mark: ptal? :)
4 years, 3 months ago (2016-08-29 11:07:49 UTC) #3
Mark Mentovai
LGTM
4 years, 3 months ago (2016-08-29 14:32:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289673003/1
4 years, 3 months ago (2016-08-29 14:34:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 15:20:58 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 15:22:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32f65a0c6b303fe3619bb33ac62f687ab4eb2553
Cr-Commit-Position: refs/heads/master@{#415012}

Powered by Google App Engine
This is Rietveld 408576698