Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: src/parsing/parser.h

Issue 2289663002: [parser] Hide expression classifiers in parser implementation (Closed)
Patch Set: Simpler and better version Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index 92ab770a9fbecc05fc0005cadf22f538abfe1d3f..afd490cbe4612a88e758fccda71d01e6e9926018 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -146,9 +146,6 @@ struct ParserTypes<Parser> {
typedef v8::internal::AstProperties AstProperties;
- typedef v8::internal::ExpressionClassifier<ParserTypes<Parser>>
- ExpressionClassifier;
-
// Return types for traversing functions.
typedef const AstRawString* Identifier;
typedef v8::internal::Expression* Expression;
@@ -477,7 +474,6 @@ class Parser : public ParserBase<Parser> {
void DesugarAsyncFunctionBody(const AstRawString* function_name, Scope* scope,
ZoneList<Statement*>* body,
- ExpressionClassifier* classifier,
FunctionKind kind, FunctionBodyType type,
bool accept_IN, int pos, bool* ok);
@@ -489,8 +485,7 @@ class Parser : public ParserBase<Parser> {
int function_token_position, FunctionLiteral::FunctionType type,
LanguageMode language_mode, bool* ok);
- Expression* ParseClassLiteral(ExpressionClassifier* classifier,
- const AstRawString* name,
+ Expression* ParseClassLiteral(const AstRawString* name,
Scanner::Location class_name_location,
bool name_is_strict_reserved, int pos,
bool* ok);
@@ -612,12 +607,10 @@ class Parser : public ParserBase<Parser> {
void ParseAsyncArrowSingleExpressionBody(ZoneList<Statement*>* body,
bool accept_IN,
- ExpressionClassifier* classifier,
int pos, bool* ok) {
- DesugarAsyncFunctionBody(ast_value_factory()->empty_string(), scope(), body,
- classifier, kAsyncArrowFunction,
- FunctionBodyType::kSingleExpression, accept_IN,
- pos, ok);
+ DesugarAsyncFunctionBody(
+ ast_value_factory()->empty_string(), scope(), body, kAsyncArrowFunction,
+ FunctionBodyType::kSingleExpression, accept_IN, pos, ok);
}
ZoneList<Expression*>* PrepareSpreadArguments(ZoneList<Expression*>* list);
@@ -644,7 +637,7 @@ class Parser : public ParserBase<Parser> {
V8_INLINE Expression* RewriteSpreads(ArrayLiteral* lit);
// Rewrite expressions that are not used as patterns
- V8_INLINE void RewriteNonPattern(ExpressionClassifier* classifier, bool* ok);
+ V8_INLINE void RewriteNonPattern(bool* ok);
V8_INLINE void QueueDestructuringAssignmentForRewriting(
Expression* assignment);
@@ -982,10 +975,9 @@ class Parser : public ParserBase<Parser> {
V8_INLINE void DeclareFormalParameter(
DeclarationScope* scope,
- const ParserFormalParameters::Parameter& parameter,
- ExpressionClassifier* classifier) {
+ const ParserFormalParameters::Parameter& parameter) {
bool is_duplicate = false;
- bool is_simple = classifier->is_simple_parameter_list();
+ bool is_simple = classifier()->is_simple_parameter_list();
auto name = is_simple || parameter.is_rest
? parameter.name
: ast_value_factory()->empty_string();
@@ -996,7 +988,7 @@ class Parser : public ParserBase<Parser> {
scope->DeclareParameter(name, mode, is_optional, parameter.is_rest,
&is_duplicate, ast_value_factory());
if (is_duplicate) {
- classifier->RecordDuplicateFormalParameterError(scanner()->location());
+ classifier()->RecordDuplicateFormalParameterError(scanner()->location());
}
if (is_sloppy(scope->language_mode())) {
// TODO(sigurds) Mark every parameter as maybe assigned. This is a

Powered by Google App Engine
This is Rietveld 408576698