Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: chrome/browser/chromeos/login/wizard_controller.cc

Issue 2289643003: ChromeOS: Fix "continue OOBE on restart" functionality. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/startup_utils.cc ('k') | chrome/browser/ui/webui/chromeos/login/oobe_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/wizard_controller.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc
index 3342221262e913cd1e877d54650bc3f0e549c1a1..5b4a3c475fe62a91ba7bdbdb42abe6eeaf4eb8fd 100644
--- a/chrome/browser/chromeos/login/wizard_controller.cc
+++ b/chrome/browser/chromeos/login/wizard_controller.cc
@@ -184,6 +184,11 @@ void InitializeCrashReporter() {
}
#endif
+bool UseMDOobe() {
+ return base::CommandLine::ForCurrentProcess()->HasSwitch(
+ chromeos::switches::kEnableMdOobe);
+}
+
} // namespace
namespace chromeos {
@@ -314,6 +319,10 @@ void WizardController::Init(const std::string& first_screen_name) {
// an eligible controller is detected later.
SetControllerDetectedPref(false);
+ // If flag disappeared after restart, disable.
+ if (!UseMDOobe())
+ GetLocalState()->SetBoolean(prefs::kOobeMdMode, false);
+
AdvanceToScreen(first_screen_name_);
if (!IsMachineHWIDCorrect() && !StartupUtils::IsDeviceRegistered() &&
first_screen_name_.empty())
@@ -920,7 +929,9 @@ void WizardController::OnHIDScreenNecessityCheck(bool screen_needed) {
if (screen_needed) {
ShowHIDDetectionScreen();
} else {
- oobe_ui_->EnableMdOobe();
+ if (UseMDOobe())
+ GetLocalState()->SetBoolean(prefs::kOobeMdMode, true);
+
ShowNetworkScreen();
}
}
@@ -976,7 +987,9 @@ void WizardController::AdvanceToScreen(const std::string& screen_name) {
weak_factory_.GetWeakPtr());
oobe_ui_->GetHIDDetectionView()->CheckIsScreenRequired(on_check);
} else {
- oobe_ui_->EnableMdOobe();
+ if (UseMDOobe())
+ GetLocalState()->SetBoolean(prefs::kOobeMdMode, true);
+
ShowNetworkScreen();
}
} else {
« no previous file with comments | « chrome/browser/chromeos/login/startup_utils.cc ('k') | chrome/browser/ui/webui/chromeos/login/oobe_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698