Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2289643003: ChromeOS: Fix "continue OOBE on restart" functionality. (Closed)

Created:
4 years, 3 months ago by Alexander Alekseev
Modified:
4 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Fix "continue OOBE on restart" functionality. This CL allows polymer-based OOBE to continue on chrome restart. BUG=604119 TEST=none Committed: https://crrev.com/83adcdae9b7977afabd5891451bebe44c7acf831 Cr-Commit-Position: refs/heads/master@{#415523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M chrome/browser/chromeos/login/startup_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Alexander Alekseev
Please review.
4 years, 3 months ago (2016-08-30 07:27:05 UTC) #2
achuithb
lgtm
4 years, 3 months ago (2016-08-30 08:00:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289643003/1
4 years, 3 months ago (2016-08-31 00:53:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 00:58:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:59:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83adcdae9b7977afabd5891451bebe44c7acf831
Cr-Commit-Position: refs/heads/master@{#415523}

Powered by Google App Engine
This is Rietveld 408576698