src/full-codegen/x64/full-codegen-x64.cc - Issue 2289613002: [turbofan] Remove special JSForInStep and JSForInDone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2289613002: [turbofan] Remove special JSForInStep and JSForInDone. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 831e74a3c680f1f89e96d3478036ed6de1ba7a64..85c07ea37b6db8fc5ace111bb2bac1bfccdf20e5 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -1086,6 +1086,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// Generate code for going to the next element by incrementing the

// index (smi) stored on top of the stack.

__ bind(loop_statement.continue_label());

+ PrepareForBailoutForId(stmt->IncrementId(), BailoutState::NO_REGISTERS);

__ SmiAddConstant(Operand(rsp, 0 * kPointerSize), Smi::FromInt(1));

EmitBackEdgeBookkeeping(stmt, &loop);