Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: src/compiler/verifier.cc

Issue 2289613002: [turbofan] Remove special JSForInStep and JSForInDone. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 386e32ea1caa7e9095285e74abeace09d537d72a..602aa30fd38fe688d4b327dbccb21be2d11c7cdf 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -635,23 +635,10 @@ void Verifier::Visitor::Check(Node* node) {
CheckUpperIs(node, Type::Any());
break;
}
- case IrOpcode::kJSForInDone: {
- // TODO(bmeurer): OSR breaks this invariant, although the node is not user
- // visible, so we know it is safe (fullcodegen has an unsigned smi there).
- // CheckValueInputIs(node, 0, Type::UnsignedSmall());
- break;
- }
case IrOpcode::kJSForInNext: {
CheckUpperIs(node, Type::Union(Type::Name(), Type::Undefined(), zone));
break;
}
- case IrOpcode::kJSForInStep: {
- // TODO(bmeurer): OSR breaks this invariant, although the node is not user
- // visible, so we know it is safe (fullcodegen has an unsigned smi there).
- // CheckValueInputIs(node, 0, Type::UnsignedSmall());
- CheckUpperIs(node, Type::UnsignedSmall());
- break;
- }
case IrOpcode::kJSLoadMessage:
case IrOpcode::kJSStoreMessage:
« no previous file with comments | « src/compiler/typer.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698