Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2289593006:
Fix recording of kAnimatingScrollOnMain (Closed)
|
Created:
4 years, 3 months ago by Ian Vollick Modified:
4 years, 3 months ago Reviewers:
tdresser CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org, skobes Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix recording of kAnimatingScrollOnMain
We only want to record this reason if it's the only scroll reason (as it
obscures others).
BUG=None
Committed: https://crrev.com/e23a88c56d23a8c7597953f6095b70d10c52859e
Cr-Commit-Position: refs/heads/master@{#415382}
Patch Set 1 #Patch Set 2 : update unit test. #
Total comments: 2
Patch Set 3 : update comment #Patch Set 4 : update comment #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by vollick@chromium.org to run a CQ dry run
Description was changed from ========== Fix recording of kAnimationScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ========== to ========== Fix recording of kAnimationScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ==========
vollick@chromium.org changed reviewers: + tdresser@chromium.org
Description was changed from ========== Fix recording of kAnimationScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ========== to ========== Fix recording of kAnimatingScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by vollick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks! https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_h... File ui/events/blink/input_handler_proxy_unittest.cc (right): https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_h... ui/events/blink/input_handler_proxy_unittest.cc:2783: cc::MainThreadScrollingReason::kAnimatingScrollOnMainThread); Maybe add a comment to the test indicating why animating scroll on the main thread is special?
https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_h... File ui/events/blink/input_handler_proxy_unittest.cc (right): https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_h... ui/events/blink/input_handler_proxy_unittest.cc:2783: cc::MainThreadScrollingReason::kAnimatingScrollOnMainThread); On 2016/08/30 15:07:56, tdresser wrote: > Maybe add a comment to the test indicating why animating scroll on the main > thread is special? Done.
The CQ bit was checked by vollick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdresser@chromium.org Link to the patchset: https://codereview.chromium.org/2289593006/#ps60001 (title: "update comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix recording of kAnimatingScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ========== to ========== Fix recording of kAnimatingScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix recording of kAnimatingScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None ========== to ========== Fix recording of kAnimatingScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None Committed: https://crrev.com/e23a88c56d23a8c7597953f6095b70d10c52859e Cr-Commit-Position: refs/heads/master@{#415382} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e23a88c56d23a8c7597953f6095b70d10c52859e Cr-Commit-Position: refs/heads/master@{#415382} |
