Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2289593006: Fix recording of kAnimatingScrollOnMain (Closed)

Created:
4 years, 3 months ago by Ian Vollick
Modified:
4 years, 3 months ago
Reviewers:
tdresser
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org, skobes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix recording of kAnimatingScrollOnMain We only want to record this reason if it's the only scroll reason (as it obscures others). BUG=None Committed: https://crrev.com/e23a88c56d23a8c7597953f6095b70d10c52859e Cr-Commit-Position: refs/heads/master@{#415382}

Patch Set 1 #

Patch Set 2 : update unit test. #

Total comments: 2

Patch Set 3 : update comment #

Patch Set 4 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M ui/events/blink/input_handler_proxy.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Ian Vollick
4 years, 3 months ago (2016-08-30 02:47:18 UTC) #5
tdresser
LGTM, thanks! https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_handler_proxy_unittest.cc File ui/events/blink/input_handler_proxy_unittest.cc (right): https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_handler_proxy_unittest.cc#newcode2783 ui/events/blink/input_handler_proxy_unittest.cc:2783: cc::MainThreadScrollingReason::kAnimatingScrollOnMainThread); Maybe add a comment to the ...
4 years, 3 months ago (2016-08-30 15:07:56 UTC) #13
Ian Vollick
https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_handler_proxy_unittest.cc File ui/events/blink/input_handler_proxy_unittest.cc (right): https://codereview.chromium.org/2289593006/diff/20001/ui/events/blink/input_handler_proxy_unittest.cc#newcode2783 ui/events/blink/input_handler_proxy_unittest.cc:2783: cc::MainThreadScrollingReason::kAnimatingScrollOnMainThread); On 2016/08/30 15:07:56, tdresser wrote: > Maybe add ...
4 years, 3 months ago (2016-08-30 17:55:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289593006/60001
4 years, 3 months ago (2016-08-30 17:56:06 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 19:02:46 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:04:12 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e23a88c56d23a8c7597953f6095b70d10c52859e
Cr-Commit-Position: refs/heads/master@{#415382}

Powered by Google App Engine
This is Rietveld 408576698