Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2289573002: [turbofan] Remove the unused asm.js types from TypeCache. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
titzer, Jarin, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the unused asm.js types from TypeCache. For asm.js we now have a dedicated AsmTyper, that uses it's own type system (which is tailored towards asm.js), and so we don't need the special asm.js types anymore in the TypeCache. This also moves the TypeCache into the src/compiler directory, because it doesn't make sense to use outside anyways. TBR=ahaas@chromium.org R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/f5a37d13bcee05875f675cb07535e8ac87266807 Cr-Commit-Position: refs/heads/master@{#38964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -279 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/asmjs/asm-typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-info.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/access-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/escape-analysis.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-global-object-specialization.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operation-typer.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/operation-typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/type-cache.h View 3 chunks +5 lines, -37 lines 0 comments Download
A + src/compiler/type-cache.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/typed-optimization.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typed-optimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/type-cache.h View 1 chunk +0 lines, -174 lines 0 comments Download
D src/type-cache.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-29 05:49:07 UTC) #1
Benedikt Meurer
Hey Jaro, Mechanical move and removal. Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-08-29 05:51:16 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-29 06:01:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289573002/1
4 years, 3 months ago (2016-08-29 06:02:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 06:12:28 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f5a37d13bcee05875f675cb07535e8ac87266807 Cr-Commit-Position: refs/heads/master@{#38964}
4 years, 3 months ago (2016-08-29 06:13:09 UTC) #11
titzer
4 years, 3 months ago (2016-08-29 12:20:20 UTC) #12
Message was sent while issue was closed.
On 2016/08/29 06:13:09, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f5a37d13bcee05875f675cb07535e8ac87266807
> Cr-Commit-Position: refs/heads/master@{#38964}

lgtm

Powered by Google App Engine
This is Rietveld 408576698