Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2289543005: Allow suspension prior to reaching kHaveFutureData. (Closed)
Patch Set: Rename to setPaused. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 5889a8f795c07f25f1ac9d8627c0aa344c51fb03..77d21443a25bcabd30322b1bf853723db87260fe 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -1135,6 +1135,8 @@ void HTMLMediaElement::startPlayerLoad(const KURL& playerProvidedUrl)
m_webMediaPlayer->setPreload(effectivePreloadType());
+ m_webMediaPlayer->setPaused(m_paused);
+
m_webMediaPlayer->load(loadType(), source, corsMode());
if (isFullscreen()) {
@@ -3175,6 +3177,11 @@ void HTMLMediaElement::updatePlayState()
mediaControls()->playbackStopped();
}
+ // |m_playing| and |m_paused| may diverge prior to kHaveFutureData, keep the
+ // WebMediaPlayer up to date despite this divergence.
+ if (webMediaPlayer())
+ webMediaPlayer()->setPaused(m_paused);
+
if (layoutObject())
layoutObject()->updateFromElement();
}

Powered by Google App Engine
This is Rietveld 408576698