IPC->mojo of audio_renderer_host

media/mojo/interfaces/audio_output.mojom

Index: media/mojo/interfaces/audio_output.mojom
diff --git a/media/mojo/interfaces/audio_output.mojom b/media/mojo/interfaces/audio_output.mojom
index 895a93e4967727e4d2846679b50433a2de46ff94..f7015f102e189983ca5214a99a22a3d3931ea783 100644
--- a/media/mojo/interfaces/audio_output.mojom
+++ b/media/mojo/interfaces/audio_output.mojom
@@ -5,29 +5,32 @@
 module media.mojom;
 
 import "media/mojo/interfaces/audio_parameters.mojom";
+import "url/mojo/origin.mojom";
+
+enum OutputDeviceStatus;
 
-// This interface handles audio output stream operations.
-// It allows to close a stream.
-// TODO(rchtara): Add methods that allow the interaction with audio output
-// streams: Play, Pause and SetVolume to this interface.
-// See crbug.com/606707 for more details.
 interface AudioOutputStream {

[o1ka, 2016/09/02 15:02:07]

We need to make sure there are no cases when browser side can generate an error
without us issuing an operation. It probably can: it can be just some system
device error, like device is unplugged. So we probably still need a client with
OnError() method.

-  Close();
+  Start(AudioParameters params) =>
+      (bool ok,
+       handle<shared_buffer> shared_buffer,
+       handle socket_descriptor);
+  Play() => (bool ok);
+  Pause() => (bool ok);
+  SetVolume(double volume) => (bool ok);
 };
 
-// This interface manages audio output streams.
-// It allows to create an AudioOutputStream.
-// TODO(rchtara): Add a method to request device authorization to this
-// interface.
-// See crbug.com/606707 for more details.
+// AudioOutput manages device authorizations and AudioOutputStreamClients

[o1ka, 2016/09/02 15:02:07]

It does not manage clients even if we introduce them back.

[Max Morin, 2016/09/02 15:34:53]

Done.

 interface AudioOutput {
-  // TODO(rchtara): Remove |stream_id| from AudioOutput::CreateStream when all
-  // the stream operations are mojofied.
-  CreateStream(
-      int32 stream_id,
-      AudioParameters params) =>
-      (int32 stream_id,
-       AudioOutputStream? stream,
-       handle<shared_buffer>? shared_buffer,
-       handle? socket_descriptor);
-};
+  // Used to request device authorization from the AudioOutputService.
+  // Returns an AudioOutputStream which can optionally be used for audio output.
+  RequestDeviceAuthorization(
+      int64 render_frame_id,
+      int64 session_id,

[o1ka, 2016/09/02 15:02:07]

Why both of them are int64?

[Max Morin, 2016/09/02 15:34:53]

They are int in the C++, so we have to make it 64 bit to be sure it's wide
enough. Then we have (safely) cast it back int on the browser side.

[o1ka, 2016/09/05 08:24:28]

Ok, we need to make sure there are no security problems with that.

+      string device_id,
+      url.mojom.Origin origin) =>
+      (AudioOutputStream stream,

[o1ka, 2016/09/02 15:02:07]

Probably we should not return a stream if device is not authorized - if this
possible? We basically are not allowed to do anything with the stream if
authorization fails

[Max Morin, 2016/09/02 15:34:53]

Done.

+       // TODO make this a struct?
+       OutputDeviceStatus state,
+       AudioParameters output_params,
+       string matched_device_id);
+};