IPC->mojo of audio_renderer_host

media/audio/audio_output_device.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/audio_output_device.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <cmath>
@@ skipping 260 matching lines @@
   audio_callback_.reset();
   stopping_hack_ = false;
 }
 
 void AudioOutputDevice::SetVolumeOnIOThread(double volume) {
   DCHECK(task_runner()->BelongsToCurrentThread());
   if (state_ >= CREATING_STREAM)
     ipc_->SetVolume(volume);
 }
 
-void AudioOutputDevice::OnStateChanged(AudioOutputIPCDelegateState state) {
+void AudioOutputDevice::OnStateChanged(mojom::AudioOutputStreamState state) {
   DCHECK(task_runner()->BelongsToCurrentThread());
 
   // Do nothing if the stream has been closed.
   if (state_ < CREATING_STREAM)
     return;
 
   // TODO(miu): Clean-up inconsistent and incomplete handling here.
   // http://crbug.com/180640
   switch (state) {
-    case AUDIO_OUTPUT_IPC_DELEGATE_STATE_PLAYING:
-    case AUDIO_OUTPUT_IPC_DELEGATE_STATE_PAUSED:
+    case mojom::AudioOutputStreamState::PLAYING:

[Henrik Grunell, 2016/09/01 15:09:07]

This seems to be an old IPC legacy. Play() and Pause() (and SetVolume()?) should
send a response instead. I don't think there are any cases where we could not
send a response that replaces usage of the "state changed" function.

+    case mojom::AudioOutputStreamState::PAUSED:
       break;
-    case AUDIO_OUTPUT_IPC_DELEGATE_STATE_ERROR:
+    case mojom::AudioOutputStreamState::ERROR:
       DLOG(WARNING) << "AudioOutputDevice::OnStateChanged(ERROR)";
       // Don't dereference the callback object if the audio thread
       // is stopped or stopping.  That could mean that the callback
       // object has been deleted.
       // TODO(tommi): Add an explicit contract for clearing the callback
       // object.  Possibly require calling Initialize again or provide
       // a callback object via Start() and clear it in Stop().
       {
         base::AutoLock auto_lock_(audio_thread_lock_);
         if (audio_thread_)
@@ skipping 188 matching lines @@
   render_callback_->Render(output_bus_.get(), std::round(frames_delayed),
                            frames_skipped);
 }
 
 bool AudioOutputDevice::AudioThreadCallback::
     CurrentThreadIsAudioDeviceThread() {
   return thread_checker_.CalledOnValidThread();
 }
 
 }  // namespace media