Issue 2289543002: Android: Fix benchmark regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2289543002: Android: Fix benchmark regression (Closed)

Created:
4 years, 3 months ago by Jinsuk Kim

Modified:
4 years, 3 months ago

Reviewers:
Jinsuk Kim

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Android: Fix benchmark regression Looks like explicitly not setting the layout to something with has zero bounds for the anchor view for the power save blocker has some effect on the benchmark. BUG=635515 TBR=jinsukkim@chromium.org Review-Url: https://codereview.chromium.org/2282983004 Cr-Commit-Position: refs/heads/master@{#414840} (cherry picked from commit 2ed2ebe585894c44ab7946fe63aa9676349e4b4f) Committed: https://chromium.googlesource.com/chromium/src/+/2cf4e3e29b9caf2f734da7ca730c075aea246ea4

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	device/power_save_blocker/power_save_blocker_android.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/android/view_android.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Jinsuk Kim

4 years, 3 months ago (2016-08-28 23:15:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2cf4e3e29b9caf2f734da7ca730c075aea246ea4.