Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2289493002: Revert of "[heap] Switch to 500k pages" (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "[heap] Switch to 500k pages" (patchset #1 id:1 of https://codereview.chromium.org/2278653003/ ) Reason for revert: Tanks pretty much alle metrics across the board. Probably LO space limit too low but needs investigation. Original issue's description: > [heap] Switch to 500k pages > > Decrease regular heap object size to 400k. In a follow up, we can now get rid of > the new space border page while keeping the 1M minimum new space size. > > This reverts commit 1617043c1093870d67eede7828467cc3b77ba9fb. > > BUG=chromium:636331 > > Committed: https://crrev.com/2101e691caeef656eb91f1c98620b3955d337c83 > Cr-Commit-Position: refs/heads/master@{#38916} TBR=ulan@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:636331 NOPRESUBMIT=true Committed: https://crrev.com/933195a24c08ed373397c083191a7a5d7f93f7c8 Cr-Commit-Position: refs/heads/master@{#38960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -300 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +2 lines, -13 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +11 lines, -72 lines 0 comments Download
M src/isolate.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +12 lines, -4 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 4 chunks +67 lines, -3 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 4 chunks +7 lines, -20 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 4 chunks +11 lines, -120 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Lippautz
Created Revert of "[heap] Switch to 500k pages"
4 years, 3 months ago (2016-08-28 07:02:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289493002/1
4 years, 3 months ago (2016-08-28 07:02:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22738)
4 years, 3 months ago (2016-08-28 07:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289493002/1
4 years, 3 months ago (2016-08-28 07:14:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-28 07:28:26 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-28 07:28:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/933195a24c08ed373397c083191a7a5d7f93f7c8
Cr-Commit-Position: refs/heads/master@{#38960}

Powered by Google App Engine
This is Rietveld 408576698