src/heap-snapshot-generator.cc - Issue 228943009: MIPS: Add big-endian support for MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 228943009: MIPS: Add big-endian support for MIPS. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Comments addressed Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 0f3e6ad413f270719dc546e792aa45ce8ebf73bc..d89096de8b521b1eefc849c924495140e743ea0f 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -1081,7 +1081,9 @@ class IndexedReferencesExtractor : public ObjectVisitor {

Address field = obj->address() + offset;

ASSERT(!Memory::Object_at(field)->IsFailure());

ASSERT(Memory::Object_at(field)->IsHeapObject());

- *field |= kFailureTag;

+ Object* untagged = *reinterpret_cast<Object**>(field);

+ intptr_t tagged = reinterpret_cast<intptr_t>(untagged) | kFailureTag;

+ *reinterpret_cast<Object**>(field) = reinterpret_cast<Object*>(tagged);

}

private:

« no previous file with comments | « src/globals.h ('k') | src/mips/assembler-mips.h » ('j') | no next file with comments »