Avoid hash table lookup for every attribute

Avoid hash table lookup for every attribute

We should avoid looking at the hash table of event handler attributes
for all attributes which don't start with "on", which is most attributes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171427

[eseidel, 2014-04-14 05:48:20]

lgtm

https://codereview.chromium.org/228943008/diff/1/Source/core/html/HTMLElement...
File Source/core/html/HTMLElement.cpp (right):

https://codereview.chromium.org/228943008/diff/1/Source/core/html/HTMLElement...
Source/core/html/HTMLElement.cpp:208: if (!attrName.localName().startsWith("on",
false))
What does the false mean?  (Clearly we should make that an enum at some point.)

[esprehn, 2014-04-14 05:50:08]

On 2014/04/14 05:48:20, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/228943008/diff/1/Source/core/html/HTMLElement...
> File Source/core/html/HTMLElement.cpp (right):
> 
>
https://codereview.chromium.org/228943008/diff/1/Source/core/html/HTMLElement...
> Source/core/html/HTMLElement.cpp:208: if
(!attrName.localName().startsWith("on",
> false))
> What does the false mean?  (Clearly we should make that an enum at some
point.)

startsWith(..., & bool caseSensitive = true)

[esprehn, 2014-04-14 05:50:10]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-14 05:50:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/228943008/1

[eseidel, 2014-04-14 05:50:50]

So this is actually only case insensitive for html. :)

[esprehn, 2014-04-14 05:52:19]

On 2014/04/14 05:50:50, eseidel wrote:
> So this is actually only case insensitive for html. :)

Yeah, but the hash table will deal with it for us... but then looking at the
code setAttribute("ONCLICK", "...") doesn't seem like it will work??

[commit-bot: I haz the power, 2014-04-14 06:52:44]

Change committed as 171427