Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2289403002: Making SetInkDropMode public (Closed)

Created:
4 years, 3 months ago by djacobo_
Modified:
4 years, 3 months ago
Reviewers:
bruthig
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making SetInkDropMode public Setting accessory method for InkDropMode public, also removing the accessory at ink_drop_host_view_test_api.* as it's no longer needed. BUG=638063 TEST=NA

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : Fixing unit test v2.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M ui/views/animation/ink_drop_host_view.h View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/views/animation/ink_drop_host_view_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M ui/views/animation/test/ink_drop_host_view_test_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/animation/test/ink_drop_host_view_test_api.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (14 generated)
djacobo_
The CQ bit was checked by djacobo@google.com to run a CQ dry run
4 years, 3 months ago (2016-08-30 21:07:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289403002/1
4 years, 3 months ago (2016-08-30 21:08:37 UTC) #2
djacobo_
Description was changed from ========== Making SetInkDropMode public Setting accessory method for InkDropMode public, also ...
4 years, 3 months ago (2016-08-30 21:08:51 UTC) #3
djacobo_
djacobo@google.com changed reviewers: + bruthig@chromium.org
4 years, 3 months ago (2016-08-30 21:08:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-30 21:24:57 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/255355) linux_chromium_rel_ng on ...
4 years, 3 months ago (2016-08-30 21:24:58 UTC) #6
djacobo_
The CQ bit was checked by djacobo@google.com to run a CQ dry run
4 years, 3 months ago (2016-08-30 23:56:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289403002/20001
4 years, 3 months ago (2016-08-30 23:57:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-31 00:12:18 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/270382)
4 years, 3 months ago (2016-08-31 00:12:19 UTC) #10
djacobo_
The CQ bit was checked by djacobo@google.com to run a CQ dry run
4 years, 3 months ago (2016-08-31 00:29:06 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289403002/40001
4 years, 3 months ago (2016-08-31 00:29:56 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-31 01:24:07 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:24:08 UTC) #14 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698