Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: src/gpu/vk/GrVkGpuCommandBuffer.cpp

Issue 2289363005: Improve usage of window rectangles (Closed) Base URL: https://skia.googlesource.com/skia.git@upload_drawsinreducedclip
Patch Set: comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/vk/GrVkGpuCommandBuffer.cpp
diff --git a/src/gpu/vk/GrVkGpuCommandBuffer.cpp b/src/gpu/vk/GrVkGpuCommandBuffer.cpp
index d7a030d24156bafa10e4c588480210db287af8bf..83e9cb17c72909d15ea26a487cf239bc917656ce 100644
--- a/src/gpu/vk/GrVkGpuCommandBuffer.cpp
+++ b/src/gpu/vk/GrVkGpuCommandBuffer.cpp
@@ -170,6 +170,7 @@ void GrVkGpuCommandBuffer::onClearStencilClip(GrRenderTarget* target,
const GrFixedClip& clip,
bool insideStencilMask) {
SkASSERT(target);
+ SkASSERT(clip.windowRectangles().disabled());
GrVkRenderTarget* vkRT = static_cast<GrVkRenderTarget*>(target);
GrStencilAttachment* sb = target->renderTargetPriv().getStencilAttachment();
@@ -223,6 +224,7 @@ void GrVkGpuCommandBuffer::onClearStencilClip(GrRenderTarget* target,
void GrVkGpuCommandBuffer::onClear(GrRenderTarget* target, const GrFixedClip& clip, GrColor color) {
// parent class should never let us get here with no RT
SkASSERT(target);
+ SkASSERT(clip.windowRectangles().disabled());
VkClearColorValue vkColor;
GrColorToRGBAFloat(color, vkColor.float32);
« src/gpu/GrFixedClip.h ('K') | « src/gpu/gl/GrGLGpu.cpp ('k') | tests/ProxyTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698