Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/cast_certificate/cast_crl.cc

Issue 2289363004: Add error information to VerifySignedData(). (Closed)
Patch Set: checkpoint Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_certificate/cast_crl.cc
diff --git a/components/cast_certificate/cast_crl.cc b/components/cast_certificate/cast_crl.cc
index 600b5efd4aec3998470b4c896dee55ffd18ca6c1..e7520f962b1692ab33cac6be846dde5aca87c294 100644
--- a/components/cast_certificate/cast_crl.cc
+++ b/components/cast_certificate/cast_crl.cc
@@ -125,10 +125,12 @@ bool VerifyCRL(const Crl& crl,
auto signature_policy = CreateCastSignaturePolicy();
std::unique_ptr<net::SignatureAlgorithm> signature_algorithm_type =
net::SignatureAlgorithm::CreateRsaPkcs1(net::DigestAlgorithm::Sha256);
+ net::CertErrors errors;
if (!VerifySignedData(*signature_algorithm_type,
net::der::Input(&crl.tbs_crl()),
signature_value_bit_string, parsed_cert->tbs().spki_tlv,
- signature_policy.get())) {
+ signature_policy.get(), &errors)) {
+ // TODO(634443): Dump the error information.
VLOG(2) << "CRL - Signature verification failed.";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698