Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2289353003: Make Enqueuer a pure interface. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -167 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +5 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 13 chunks +81 lines, -85 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 15 chunks +29 lines, -59 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_tree_shaking_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
4 years, 3 months ago (2016-08-31 13:05:03 UTC) #3
Johnni Winther
ping
4 years, 3 months ago (2016-09-01 08:01:07 UTC) #4
sra1
lgtm
4 years, 3 months ago (2016-09-01 15:12:55 UTC) #5
Johnni Winther
4 years, 3 months ago (2016-09-02 07:00:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
380c0bf3cb3a217c4ad612fc7f15bd1e93f989c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698