Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: infra/bots/recipe_modules/vars/api.py

Issue 2289343002: GN: add sanitize arg (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipe_modules/vars/api.py
diff --git a/infra/bots/recipe_modules/vars/api.py b/infra/bots/recipe_modules/vars/api.py
index 5418e26022cc33706588836df03a95e016ba861d..54da3b3559d329880e9815f32a60254b3da006d0 100644
--- a/infra/bots/recipe_modules/vars/api.py
+++ b/infra/bots/recipe_modules/vars/api.py
@@ -82,16 +82,14 @@ class SkiaVarsApi(recipe_api.RecipeApi):
self.tmp_dir = self.m.path['slave_build'].join('tmp')
# Some bots also require a checkout of chromium.
- self.need_chromium_checkout = 'CommandBuffer' in self.builder_name
+ self.need_chromium_checkout = False
if 'CommandBuffer' in self.builder_name:
+ self.need_chromium_checkout = True
self.gclient_env['GYP_CHROMIUM_NO_ACTION'] = '0'
- if ((self.is_compile_bot and
- 'SAN' in self.builder_name) or
- 'RecreateSKPs' in self.builder_name):
+ if 'RecreateSKPs' in self.builder_name:
self.need_chromium_checkout = True
- if 'RecreateSKPs' in self.builder_name:
- self.gclient_env['CPPFLAGS'] = (
- '-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1')
+ self.gclient_env['CPPFLAGS'] = (
+ '-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1')
# Some bots also require a checkout of PDFium.
self.need_pdfium_checkout = 'PDFium' in self.builder_name

Powered by Google App Engine
This is Rietveld 408576698