Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: infra/bots/recipe_modules/flavor/api.py

Issue 2289343002: GN: add sanitize arg (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipe_modules/flavor/api.py
diff --git a/infra/bots/recipe_modules/flavor/api.py b/infra/bots/recipe_modules/flavor/api.py
index bff316a9e7aacd293757c591da1a9e746acc171a..21ee590dc592a1831a13d57d573a501fc99c6b76 100644
--- a/infra/bots/recipe_modules/flavor/api.py
+++ b/infra/bots/recipe_modules/flavor/api.py
@@ -17,7 +17,6 @@ from . import gn_flavor
from . import ios_flavor
from . import pdfium_flavor
from . import valgrind_flavor
-from . import xsan_flavor
TEST_EXPECTED_SKP_VERSION = '42'
@@ -54,12 +53,6 @@ def is_valgrind(builder_cfg):
return 'Valgrind' in builder_cfg.get('extra_config', '')
-def is_xsan(builder_cfg):
- return ('ASAN' in builder_cfg.get('extra_config', '') or
- 'MSAN' in builder_cfg.get('extra_config', '') or
- 'TSAN' in builder_cfg.get('extra_config', ''))
-
-
class SkiaFlavorApi(recipe_api.RecipeApi):
def get_flavor(self, builder_cfg):
"""Return a flavor utils object specific to the given builder."""
@@ -81,8 +74,6 @@ class SkiaFlavorApi(recipe_api.RecipeApi):
return pdfium_flavor.PDFiumFlavorUtils(self.m)
elif is_valgrind(builder_cfg):
return valgrind_flavor.ValgrindFlavorUtils(self.m)
- elif is_xsan(builder_cfg):
- return xsan_flavor.XSanFlavorUtils(self.m)
elif builder_cfg.get('configuration') == 'Coverage':
return coverage_flavor.CoverageFlavorUtils(self.m)
else:

Powered by Google App Engine
This is Rietveld 408576698