Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 22893056: GTTF: make the new test launcher handle test crashes (Closed)

Created:
7 years, 4 months ago by Paweł Hajdan Jr.
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GTTF: make the new test launcher handle test crashes Test launcher now recognizes when a test crashes and schedules tests that have not been run because of the crash to run again. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219335

Patch Set 1 #

Patch Set 2 : fix clang #

Patch Set 3 : ios #

Patch Set 4 : ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -39 lines) Patch
M base/test/gtest_xml_util.h View 1 1 chunk +29 lines, -2 lines 0 comments Download
M base/test/gtest_xml_util.cc View 4 chunks +111 lines, -2 lines 0 comments Download
M base/test/test_launcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/test/test_launcher.cc View 4 chunks +23 lines, -8 lines 0 comments Download
M base/test/test_suite.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/test/test_suite.cc View 1 2 3 chunks +34 lines, -0 lines 0 comments Download
M base/test/test_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/test_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M base/test/unit_test_launcher.cc View 5 chunks +41 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 4 months ago (2013-08-23 19:15:40 UTC) #1
sky
LGTM
7 years, 4 months ago (2013-08-23 20:01:24 UTC) #2
Paweł Hajdan Jr.
7 years, 4 months ago (2013-08-23 21:09:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r219335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698