Add support for BeforeUnloadEvent

Source/bindings/v8/V8AbstractEventListener.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "config.h"
 #include "bindings/v8/V8AbstractEventListener.h"
 
 #include "V8Event.h"
 #include "V8EventTarget.h"
 #include "bindings/v8/DateExtension.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8EventListenerList.h"
 #include "bindings/v8/V8HiddenPropertyName.h"
+#include "core/dom/BeforeUnloadEvent.h"
 #include "core/dom/Document.h"
 #include "core/dom/Event.h"
 #include "core/dom/EventNames.h"
 #include "core/inspector/InspectorCounters.h"
 #include "core/page/Frame.h"
 #include "core/workers/WorkerGlobalScope.h"
 
 namespace WebCore {
 
 V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, PassRefPtr<DOMWrapperWorld> world, v8::Isolate* isolate)
@@ skipping 100 matching lines @@
     }
 
     if (event->type() == eventNames().beforeunloadEvent || event->type() == eventNames().unloadEvent)
         DateExtension::get()->setAllowSleep(true, v8Context->GetIsolate());
 
     ASSERT(!handleOutOfMemory() || returnValue.IsEmpty());
 
     if (returnValue.IsEmpty())
         return;
 
-    if (!returnValue->IsNull() && !returnValue->IsUndefined() && event->storesResultAsString())
-        event->storeResult(toWebCoreString(returnValue));
+    if (event->type() == eventNames().beforeunloadEvent && !returnValue->IsNull() && !returnValue->IsUndefined())

[arv (Not doing code reviews), 2013/08/23 13:56:49]

This doesn't look safe. What if someone dispatches a non BeforeUnloadEvent with
that type (type is just a string).

var e = new Event('beforeunload', {bubbles: true});
document.body.dispatchEvent(e);

Maybe you can use interfaceName() instead?

[do-not-use, 2013/08/23 14:20:40]

Oops, you're right. I believe the most common pattern is to use a
isBeforeUnloadEvent() virtual method and use that.

[do-not-use, 2013/08/23 14:27:54]

Done.

+        static_cast<BeforeUnloadEvent*>(event)->setReturnValue(toWebCoreString(returnValue));
 
     if (m_isAttribute && shouldPreventDefault(returnValue))
         event->preventDefault();
 }
 
 bool V8AbstractEventListener::shouldPreventDefault(v8::Local<v8::Value> returnValue)
 {
     // Prevent default action if the return value is false in accord with the spec
     // http://www.w3.org/TR/html5/webappapis.html#event-handler-attributes
     return returnValue->IsBoolean() && !returnValue->BooleanValue();
@@ skipping 12 matching lines @@
         return v8::Local<v8::Object>();
     return v8::Local<v8::Object>::New(v8::Handle<v8::Object>::Cast(value));
 }
 
 void V8AbstractEventListener::makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Object>*, V8AbstractEventListener* listener)
 {
     listener->m_listener.clear();
 }
 
 } // namespace WebCore