Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: src/ia32/cpu-ia32.cc

Issue 22893050: Get rid of duplicated CPU::DebugBreak() method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/cpu.h ('k') | src/mips/cpu-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 // invalidate already cached translated code. This leads to random 65 // invalidate already cached translated code. This leads to random
66 // instability when code patches or moves are sometimes unnoticed. One 66 // instability when code patches or moves are sometimes unnoticed. One
67 // solution is to run valgrind with --smc-check=all, but this comes at a big 67 // solution is to run valgrind with --smc-check=all, but this comes at a big
68 // performance cost. We can notify valgrind to invalidate its cache. 68 // performance cost. We can notify valgrind to invalidate its cache.
69 #ifdef VALGRIND_DISCARD_TRANSLATIONS 69 #ifdef VALGRIND_DISCARD_TRANSLATIONS
70 unsigned res = VALGRIND_DISCARD_TRANSLATIONS(start, size); 70 unsigned res = VALGRIND_DISCARD_TRANSLATIONS(start, size);
71 USE(res); 71 USE(res);
72 #endif 72 #endif
73 } 73 }
74 74
75
76 void CPU::DebugBreak() {
77 #ifdef _MSC_VER
78 // To avoid Visual Studio runtime support the following code can be used
79 // instead
80 // __asm { int 3 }
Michael Starzinger 2013/08/23 11:43:43 We could preserve these three lines of comments in
Benedikt Meurer 2013/08/23 11:50:43 Will be addressed in separate CL.
81 __debugbreak();
82 #elif defined(__native_client__)
83 asm("hlt");
84 #else
85 asm("int $3");
86 #endif
87 }
88
89 } } // namespace v8::internal 75 } } // namespace v8::internal
90 76
91 #endif // V8_TARGET_ARCH_IA32 77 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/cpu.h ('k') | src/mips/cpu-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698