Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2289303007: Re-instate ui/*compiled_resources*.gyp files (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
fukino, bshe
CC:
chromium-reviews, posciak+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1981 lines, -5 lines) Patch
A ui/file_manager/audio_player/elements/compiled_resources2.gyp View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/js/compiled_resources.gyp View 1 chunk +114 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/js/compiled_resources2.gyp View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/file_manager/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/file_manager/externs/compiled_resources2.gyp View 1 chunk +91 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 chunk +72 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/background/js/compiled_resources2.gyp View 1 chunk +143 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/common/js/compiled_resources2.gyp View 1 chunk +91 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp View 1 chunk +51 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +194 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 chunk +259 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp View 1 chunk +30 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/compiled_resources2.gyp View 1 chunk +131 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 chunk +151 lines, -0 lines 0 comments Download
A ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +159 lines, -0 lines 0 comments Download
A ui/file_manager/gallery/js/compiled_resources2.gyp View 1 chunk +91 lines, -0 lines 0 comments Download
A ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp View 1 chunk +67 lines, -0 lines 0 comments Download
A ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
A ui/file_manager/image_loader/compiled_resources2.gyp View 1 chunk +47 lines, -0 lines 0 comments Download
A ui/file_manager/video_player/js/cast/compiled_resources2.gyp View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +125 lines, -0 lines 0 comments Download
A ui/file_manager/video_player/js/compiled_resources2.gyp View 1 chunk +35 lines, -0 lines 0 comments Download
A + ui/keyboard/resources/compiled_resources.gyp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Dan Beam
4 years, 3 months ago (2016-09-02 00:57:04 UTC) #1
fukino
lgtm. Thank you!
4 years, 3 months ago (2016-09-02 01:05:53 UTC) #2
Dan Beam
TBR=bshe@ for ui/keyboard
4 years, 3 months ago (2016-09-02 01:25:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2efb0fa36b8631044419c1a60a72452bbb24dfe1 Cr-Commit-Position: refs/heads/master@{#416155}
4 years, 3 months ago (2016-09-02 01:31:15 UTC) #7
Dan Beam
4 years, 3 months ago (2016-09-02 01:32:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2efb0fa36b8631044419c1a60a72452bbb24dfe1.

Powered by Google App Engine
This is Rietveld 408576698