Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/typ/typ/runner.py

Issue 2289303002: Roll typ to v0.9.7. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/typ/typ/json_results.py ('k') | third_party/typ/typ/tests/main_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/typ/typ/runner.py
diff --git a/third_party/typ/typ/runner.py b/third_party/typ/typ/runner.py
index c2975f166e96a497741854f17193e08cf935a197..7f5aeed6cf18fc4c9da541b8de026d350f7cd8bb 100644
--- a/third_party/typ/typ/runner.py
+++ b/third_party/typ/typ/runner.py
@@ -407,6 +407,11 @@ class Runner(object):
add_tests(suite)
else:
add_tests(loader.loadTestsFromName(name))
+ if hasattr(loader, 'errors') and loader.errors:
+ # In Python3's version of unittest, loader failures get converted
+ # into failed test cases, rather than raising exceptions. However,
+ # the errors also get recorded so you can err out immediately.
+ raise ImportError(loader.errors)
def _run_tests(self, result_set, test_set):
h = self.host
« no previous file with comments | « third_party/typ/typ/json_results.py ('k') | third_party/typ/typ/tests/main_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698