Issue 22893006: Add a bootstrap script to make it easier to build gcmole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22893006: Add a bootstrap script to make it easier to build gcmole (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Sven Panne, Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a bootstrap script to make it easier to build gcmole R=machenbach@chromium.org

Patch Set 2 : updates #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -1 line)			Patch
	M	tools/gcmole/Makefile	View		1 chunk	+1 line, -1 line	1 comment	Download
	A	tools/gcmole/bootstrap.sh	View	1	1 chunk	+126 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

LGTM with nit https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/bootstrap.sh File tools/gcmole/bootstrap.sh (right): https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/bootstrap.sh#newcode124 tools/gcmole/bootstrap.sh:124: echo nit: trailing whitespace

7 years, 4 months ago (2013-08-14 12:43:30 UTC) #3

Sven Panne

7 years, 4 months ago (2013-08-14 13:07:47 UTC) #4

Late DBC...

https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/Makefile
File tools/gcmole/Makefile (right):

https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/Makefile#newc...
tools/gcmole/Makefile:43: rm -f libgcmole.so
Pro tip: Use $(RM). :-) Furthermore, clean should be .PHONY.

Expand Messages | Collapse Messages

Issue 22893006: Add a bootstrap script to make it easier to build gcmole (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages