Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2289293006: [modules] Ignore the surrounding script scope. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Ignore the surrounding script scope. This is more consistent with how we handle eval scripts. R=jochen@chromium.org BUG=v8:1569 Committed: https://crrev.com/b3b574cd8ce78b5fbd7244a85d583300af1b1680 Cr-Commit-Position: refs/heads/master@{#39069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/ast/scopes.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
neis
4 years, 3 months ago (2016-09-01 08:43:33 UTC) #1
neis
ptal
4 years, 3 months ago (2016-09-01 08:44:12 UTC) #4
marja
lgtm - this is just removing a special case, I'm assuming you know what you're ...
4 years, 3 months ago (2016-09-01 08:49:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289293006/1
4 years, 3 months ago (2016-09-01 08:53:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 09:16:15 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 09:16:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3b574cd8ce78b5fbd7244a85d583300af1b1680
Cr-Commit-Position: refs/heads/master@{#39069}

Powered by Google App Engine
This is Rietveld 408576698