Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(255)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: testing/resources/pixel/bug_585_highlight.in
Issue
2289293005
:
Use /RECT or /QuadPoints for annotation coordinates, depending on /AP (Closed)
Patch Set: Use either /RECT or /QuadPoints for annotation coordinates, depending on /AP
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
core/fpdfdoc/cpdf_annot.cpp
core/fpdfdoc/cpvt_generateap.cpp
core/fpdfdoc/include/cpdf_annot.h
testing/resources/pixel/bug_585_highlight.in
testing/resources/pixel/bug_585_highlight_expected.pdf.0.png
testing/resources/pixel/bug_585_squiggly.in
testing/resources/pixel/bug_585_squiggly_expected.pdf.0.png
testing/resources/pixel/bug_585_strikeout.in
testing/resources/pixel/bug_585_strikeout.pdf.0.png
testing/resources/pixel/bug_585_underline.in
testing/resources/pixel/bug_585_underline_expected.pdf.0.png
View unified diff
|
Download patch
« core/fpdfdoc/include/cpdf_annot.h
('K') |
« core/fpdfdoc/include/cpdf_annot.h
('k') |
testing/resources/pixel/bug_585_highlight_expected.pdf.0.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {{header}}
1 {{header}}
2 {{object 1 0}} <<
2 {{object 1 0}} <<
3 /Type /Catalog
3 /Type /Catalog
4 /Pages 2 0 R
4 /Pages 2 0 R
5
/OpenAction 20 0 R
6 >>
5 >>
7 endobj
6 endobj
8 {{object 2 0}} <<
7 {{object 2 0}} <<
9 /Type /Pages
8 /Type /Pages
10 /Count 1
9 /Count 1
11 /Kids [
10 /Kids [
12 10 0 R
11 10 0 R
13 ]
12 ]
14 >>
13 >>
15 endobj
14 endobj
16 % Page number 0.
15 % Page number 0.
17 {{object 10 0}} <<
16 {{object 10 0}} <<
18 /Type /Page
17 /Type /Page
19 /Parent 2 0 R
18 /Parent 2 0 R
20 /Resources <<
19 /Resources <<
21 /Font <</F1 15 0 R>>
20 /Font <</F1 15 0 R>>
22 >>
21 >>
23 /MediaBox [0 0 612 792]
22 /MediaBox [0 0 612 792]
24 /Annots [
23 /Annots [
25 22 0 R
24 22 0 R
26 ]
25 ]
27 /Tabs /R
26 /Tabs /R
28 >>
27 >>
29 endobj
28 endobj
30
29
31
% OpenAction action
32
{{object 20 0}} <<
33
/Type /Action
34
/S /JavaScript
35
/JS 21 0 R
36
>>
37
endobj
38
% JS program to exexute
39
{{object 21 0}} <<
40
>>
41
stream
42
var annot = this.getAnnot(0, "Annot-1");
43
annot.hidden = false;
44
endstream
45
endobj
46
47 {{object 22 0}} <<
30 {{object 22 0}} <<
48 /Type /Annot
31 /Type /Annot
49 /Subtype /Highlight
32 /Subtype /Highlight
50
/Rect [
475 681 512 690
]
33
/Rect [
-1 -1 -1 -1
]
51 /NM (Annot-1)
34 /NM (Annot-1)
52
/F
2
35
/F
4
53 /QuadPoints [ 475 688 512 688 475 679 512 679 ]
36 /QuadPoints [ 475 688 512 688 475 679 512 679 ]
54 /C [ 0.0001108646 0.001760244 0.9982184 ]
37 /C [ 0.0001108646 0.001760244 0.9982184 ]
55 /Contents ()
38 /Contents ()
56 >>
39 >>
57 endobj
40 endobj
58
41
59 {{xref}}
42 {{xref}}
60 trailer <<
43 trailer <<
61 /Root 1 0 R
44 /Root 1 0 R
62 >>
45 >>
63 {{startxref}}
46 {{startxref}}
64 %%EOF
47 %%EOF
OLD
NEW
« core/fpdfdoc/include/cpdf_annot.h
('K') |
« core/fpdfdoc/include/cpdf_annot.h
('k') |
testing/resources/pixel/bug_585_highlight_expected.pdf.0.png »
('j') |
no next file with comments »
Issue 2289293005: Use /RECT or /QuadPoints for annotation coordinates, depending on /AP (Closed)
Created 4 years, 3 months ago by tonikitoo
Modified 4 years, 3 months ago
Reviewers: Lei Zhang, Tom Sepez, dsinclair, jaepark
Base URL:
Comments: 27
This is Rietveld
408576698