Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/browser/accessibility/dump_accessibility_browsertest_base.cc

Issue 2289293004: Fix flakiness in DumpAccessibilityTree tests with iframes (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_browsertest_base.cc
diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.cc b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
index af1e10e1d7863fb022ca4133e63638c851e9d739..737d0d2955ba241724bb0fd962756fac127aff0b 100644
--- a/content/browser/accessibility/dump_accessibility_browsertest_base.cc
+++ b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
@@ -55,11 +55,8 @@ bool AccessibilityTreeContainsLoadedDocWithUrl(BrowserAccessibility* node,
if ((node->GetRole() == ui::AX_ROLE_WEB_AREA ||
node->GetRole() == ui::AX_ROLE_ROOT_WEB_AREA) &&
node->GetStringAttribute(ui::AX_ATTR_URL) == url) {
- // If possible, ensure the doc has finished loading. That's currently
- // not possible with same-process iframes until https://crbug.com/532249
- // is fixed.
- return (node->manager()->GetTreeData().url != url ||
- node->manager()->GetTreeData().loaded);
+ // Ensure the doc has finished loading.
+ return node->manager()->GetTreeData().loaded;
}
for (unsigned i = 0; i < node->PlatformChildCount(); i++) {
@@ -270,19 +267,6 @@ void DumpAccessibilityTestBase::RunTestForPlatform(
std::string url = node->current_url().spec();
if (url != url::kAboutBlankURL)
all_frame_urls.push_back(url);
-
- // We won't get the correct coordinate transformations for
- // out-of-process iframes until each frame's surface is ready.
- RenderFrameHostImpl* current_frame_host = node->current_frame_host();
- if (!current_frame_host || !current_frame_host->is_local_root())
- continue;
- RenderWidgetHostViewBase* rwhv =
- static_cast<RenderWidgetHostViewBase*>(current_frame_host->GetView());
- if (rwhv && rwhv->IsChildFrameForTesting()) {
- SurfaceHitTestReadyNotifier notifier(
- static_cast<RenderWidgetHostViewChildFrame*>(rwhv));
- notifier.WaitForSurfaceReady();
- }
}
// Wait for the accessibility tree to fully load for all frames,
« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698