Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2289293004: Fix flakiness in DumpAccessibilityTree tests with iframes (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in DumpAccessibilityTree tests with iframes I found three sources of flakiness in DumpAccessibilityTree tests with iframes: 1. Enabled a check that all frames have loaded before dumping the accessibility tree. Previously it was only possible to do that check on out-of-process iframes, but now that bug 532249 is fixed we can do that check on all iframes. 2. Removed code to check if each frame's surface is ready. It's no longer necessary now that bug 618120 is fixed, and it was causing flakiness. 3. The scroll max for the main page is sometimes flaky because it changes asynchronously after the page loads. Modified the tests to not dump scroll mins and maxes. Re-enables several disabled tests. We may be able to enable a few more in a follow-up. BUG=622387 Committed: https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2 Cr-Commit-Position: refs/heads/master@{#416103}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
dmazzoni
4 years, 3 months ago (2016-08-31 18:20:53 UTC) #3
nektarios
lgtm
4 years, 3 months ago (2016-09-01 20:38:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289293004/1
4 years, 3 months ago (2016-09-01 21:40:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 22:57:14 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 22:58:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fadb58864d3a99cd09b89d31994d4286f4cb60d2
Cr-Commit-Position: refs/heads/master@{#416103}

Powered by Google App Engine
This is Rietveld 408576698