Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: appengine/third_party/python-adb/adb/contrib/adb_commands_safe.py

Issue 2289293003: swarming: Roll py-adb to 775c24... (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/third_party/python-adb/README.swarming ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/third_party/python-adb/adb/contrib/adb_commands_safe.py
diff --git a/appengine/third_party/python-adb/adb/contrib/adb_commands_safe.py b/appengine/third_party/python-adb/adb/contrib/adb_commands_safe.py
index f4c83ad767f7c54be1e7e4a6da2c51c0b7cb9c64..917ac02d368bb4d629ab1f4dde5ba43be5625018 100644
--- a/appengine/third_party/python-adb/adb/contrib/adb_commands_safe.py
+++ b/appengine/third_party/python-adb/adb/contrib/adb_commands_safe.py
@@ -828,7 +828,8 @@ class AdbCommandsSafe(object):
except usb_exceptions.LibusbWrappingError as e:
self._failure = 'usb_failure'
_LOG.warning('I/O FAILURE: %s: %s', self.port_path, e)
- self._handle.Reset()
+ # TODO(crbug.com/642440): Reset the handle here if fleet health
+ # regresses and host kernel panics don't subside.
except adb_protocol.InvalidResponseError as e:
self._failure = 'protocol_fault'
_LOG.warning('SYNC FAILURE: %s: %s', self.port_path, e)
« no previous file with comments | « appengine/third_party/python-adb/README.swarming ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698