Eraser tool type plumbing from ui/events to web events and PPAPI.

third_party/WebKit/Source/core/events/PointerEventFactory.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/events/PointerEventFactory.h"
 
 #include "core/frame/FrameView.h"
 #include "platform/geometry/FloatSize.h"
 
 namespace blink {
 
 namespace {
 
 inline int toInt(WebPointerProperties::PointerType t) { return static_cast<int>(t); }
 
 const char* pointerTypeNameForWebPointPointerType(WebPointerProperties::PointerType type)
 {
     switch (type) {
     case WebPointerProperties::PointerType::Unknown:
         return "";
     case WebPointerProperties::PointerType::Touch:
         return "touch";
     case WebPointerProperties::PointerType::Pen:
+    case WebPointerProperties::PointerType::Eraser:

[bradnelson, 2016/08/30 18:19:29]

This meant to be the same for both ends?

[denniskempin, 2016/08/30 18:27:41]

This is for the web apis, which do not support eraser. They will eventually
convert the eraser into a button. mustaq@ is looking at that. 

[mustaq, 2016/08/30 19:13:51]

Yes, I will take care of Blink event handling.

In general, we should have either the modifier bit or a separate pointer_type,
and not both. From Blink side, we are fine with either solution but biasing
slightly towards a separate type to emphasize the diff in code.

Does PPAPI have any preference?

         return "pen";
     case WebPointerProperties::PointerType::Mouse:
         return "mouse";
     }
     NOTREACHED();
     return "";
 }
 
 const AtomicString& pointerEventNameForMouseEventName(
     const AtomicString& mouseEventName)
@@ skipping 360 matching lines @@
     if (properties.pointerType
         == WebPointerProperties::PointerType::Mouse)
         return PointerEventFactory::s_mouseId;
     IncomingId id(properties.pointerType, properties.id);
     if (m_pointerIncomingIdMapping.contains(id))
         return m_pointerIncomingIdMapping.get(id);
     return PointerEventFactory::s_invalidId;
 }
 
 } // namespace blink