Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2289263004: Remove deprecated code (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M lib/js/amd/dart_sdk.js View 3 chunks +2 lines, -3 lines 0 comments Download
M lib/js/common/dart_sdk.js View 3 chunks +2 lines, -3 lines 0 comments Download
M lib/js/es6/dart_sdk.js View 3 chunks +2 lines, -3 lines 0 comments Download
M lib/js/legacy/dart_sdk.js View 3 chunks +2 lines, -3 lines 0 comments Download
M lib/src/analyzer/context.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pubspec.lock View 6 chunks +11 lines, -5 lines 0 comments Download
M web/web_command.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 3 months ago (2016-08-30 22:21:36 UTC) #3
Brian Wilkerson
The analyzer related changes lgtm, but I have no idea about the js related changes.
4 years, 3 months ago (2016-08-30 22:37:19 UTC) #4
vsm
4 years, 3 months ago (2016-08-30 22:39:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80fcd4337743378bde800ad9a3b99b0d76d560c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698