third_party/WebKit/Source/core/input/KeyboardEventManager.cpp - Issue 2289213002: Implement Middle Click Autoscroll on all platforms not just Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2289213002: Implement Middle Click Autoscroll on all platforms not just Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename the files. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/input/ScrollManager.h » ('j') | third_party/WebKit/Source/core/page/AutoscrollController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

index e5b1abc0ea5fc708f0b649f2ad4964ecd31799f9..68097e6564e09292bc1e920e98b107bfccdbdf19 100644

--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

@@ -89,8 +89,8 @@ WebInputEventResult KeyboardEventManager::keyEvent(

capsLockStateMayHaveChanged();

#if OS(WIN)

bokan 2016/09/07 16:33:46 Should we remove this #if?

- if (m_scrollManager->panScrollInProgress()) {

- // If a key is pressed while the panScroll is in progress then we want to stop

+ if (m_scrollManager->middleClickAutoscrollInProgress()) {

+ // If a key is pressed while the middleClickAutoscroll is in progress then we want to stop

if (initialKeyEvent.type == WebInputEvent::KeyDown || initialKeyEvent.type == WebInputEvent::RawKeyDown)

m_scrollManager->stopAutoscroll();