Implement Middle Click Autoscroll on all platforms not just Windows

Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011
Committed: https://crrev.com/87f287bbe619d07e907dc00f48e2a6ad725367c1
Cr-Commit-Position: refs/heads/master@{#417454}

[sunyunjia, 2016-08-30 16:03:34]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 16:03:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-08-30 16:05:06]

sunyunjia@chromium.org changed reviewers:
+ dtapuska@chromium.org

[sunyunjia, 2016-08-30 16:05:07]

Hi Dave, I'm not sure if this is the right approach for this issue. Can you
please take a look?

[commit-bot: I haz the power, 2016-08-30 16:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:06:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunyunjia, 2016-08-30 16:48:05]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 16:48:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-08-30 17:37:57]

On 2016/08/30 at 16:05:07, sunyunjia wrote:
> Hi Dave, I'm not sure if this is the right approach for this issue. Can you
please take a look?

this seems pretty good to me. But we need to ensure that it is enabled by
default on windows.

Are there any tests associated with pan scrolling that can be enabled on all
platforms?

[commit-bot: I haz the power, 2016-08-30 18:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 18:49:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunyunjia, 2016-08-31 20:15:53]

Patchset #4 (id:60001) has been deleted

[sunyunjia, 2016-08-31 20:25:24]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:25:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:42:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunyunjia, 2016-08-31 22:24:46]

Patchset #5 (id:100001) has been deleted

[sunyunjia, 2016-08-31 22:25:37]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:26:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-08-31 22:36:50]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[sunyunjia, 2016-08-31 22:37:00]

Patchset #5 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-08-31 22:37:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:10:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunyunjia, 2016-09-01 00:11:32]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 00:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 01:39:43]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-01 01:46:24]

Patchset #4 (id:80001) has been deleted

[sunyunjia, 2016-09-01 01:50:31]

sunyunjia@chromium.org changed reviewers:
+ rbyers@chromium.org

[sunyunjia, 2016-09-01 01:50:31]

PTAL, Thanks!

https://codereview.chromium.org/2289213002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2289213002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/input/EventHandler.cpp:839:
updatePointerTargetAndDispatchEvents(EventTypeNames::mousedown, mev.innerNode(),
m_clickCount, mev.event());
I'm not sure the side effects of adding this line of code. But it helps to solve
crbug.com/548226 as well.

[Navid Zolghadr, 2016-09-02 17:36:57]

nzolghadr@chromium.org changed reviewers:
+ nzolghadr@chromium.org

[Navid Zolghadr, 2016-09-02 17:36:57]

https://codereview.chromium.org/2289213002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2289213002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/input/EventHandler.cpp:839:
updatePointerTargetAndDispatchEvents(EventTypeNames::mousedown, mev.innerNode(),
m_clickCount, mev.event());
On 2016/09/01 01:50:31, sunyunjia wrote:
> I'm not sure the side effects of adding this line of code. But it helps to
solve
> crbug.com/548226 as well.

When pan is enabled and that pan circle is shown, if you press left mouse button
this used to go to this if and disable the pan (and not send a mousedown to the
page) and when you would release the mouse it would send a mouseup to the page. 
You are now changing that behavior to also send that mousedown that we were
suppressing before. Just wanted to point that out and whether that is the
intention or not. Also in that case do we like to send the click events for
these mousedown/ups?

Also I noticed something when I was playing with pan on Windows. If I'm in pan
mode, and middle click again that also disables the pan. Does it do that after
this patch on Linux or does it remain in pan mode?

[Rick Byers, 2016-09-06 14:08:32]

Description was changed from

==========
Implement Pan Scrolling on all platforms not just Windows

BUG=522011
==========

to

==========
Implement Pan Scrolling on all platforms not just Windows

BUG=522011
==========

[Rick Byers, 2016-09-06 14:08:32]

rbyers@chromium.org changed reviewers:
+ bokan@chromium.org
- rbyers@chromium.org

[Rick Byers, 2016-09-06 14:12:00]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2016-09-06 14:12:01]

bokan@ has more context in this code than I do, so he's probably the better
core/OWNER to review this.

But the trivial changes in Source/web and Source/platform LGTM (with nit)

https://codereview.chromium.org/2289213002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/2289213002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:154: PanScrolling
status=experimental
nit: Add a comment saying this is enabled by default on Windows only (the only
part that's "experimental" is the support on other platforms).

[sunyunjia, 2016-09-07 14:11:27]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 14:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 14:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 14:53:30]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sunyunjia, 2016-09-07 15:12:31]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 15:12:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-07 15:12:54]

Patchset #5 (id:160001) has been deleted

[bokan, 2016-09-07 16:33:47]

Code looks fine.

Please add in the description that we've changed the name from Pan Scrolling to
Middle Click Autoscrolling

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/input/EventHandler.cpp:440: {
Add a DCHECK for the new RuntimeEnabledFeature here

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/input/EventHandler.h (right):

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/input/EventHandler.h:99: void
startPanScrolling(LayoutObject*);
This should be pan->middleClickAutoscroll, right?

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/input/KeyboardEventManager.cpp (right):

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/input/KeyboardEventManager.cpp:91: #if OS(WIN)
Should we remove this #if?

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/page/AutoscrollController.cpp (right):

https://codereview.chromium.org/2289213002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/page/AutoscrollController.cpp:251: case
AutoscrollForPan:
Please add a DCHECK here that the middleClickAutoScroll WebRuntimeFeature is
enabled.

[commit-bot: I haz the power, 2016-09-07 16:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:49:50]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-07 18:23:48]

Description was changed from

==========
Implement Pan Scrolling on all platforms not just Windows

BUG=522011
==========

to

==========
Implement Middle Click Autoscroll on all platforms not just Windows. This
feature is renamed from Pan Scrolling.

BUG=522011
==========

[sunyunjia, 2016-09-07 19:58:16]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:58:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 20:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:02:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sunyunjia, 2016-09-07 20:36:55]

Patchset #6 (id:200001) has been deleted

[sunyunjia, 2016-09-07 20:37:07]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-07 21:08:03]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-07 22:06:13]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:06:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:54:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:54:11]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-08 02:32:46]

sunyunjia@chromium.org changed reviewers:
+ jochen@chromium.org

[sunyunjia, 2016-09-08 02:33:30]

PTAL, thanks!

[jochen (gone - plz use gerrit), 2016-09-08 12:43:04]

content/ lgtm

please reformat the CL description according to
chromium.org/developers/contributing-code#Writing_change_list_descriptions

[jochen (gone - plz use gerrit), 2016-09-08 12:44:27]

actually, please don't rename the use counter, that'll just confuse the UMA
dashboard. Either use a new one, or stick with the old name

[dtapuska, 2016-09-08 13:09:10]

On 2016/09/08 12:44:27, jochen wrote:
> actually, please don't rename the use counter, that'll just confuse the UMA
> dashboard. Either use a new one, or stick with the old name

the use counter was just added the other day. I think it is probably ok to
rename no?

[jochen (gone - plz use gerrit), 2016-09-08 13:50:44]

can you please ask somebody from the metrics team to chime in
(//tools/metrics/OWNERS I think)?

[bokan, 2016-09-08 13:57:39]

Source/core lgtm. As Jochen mentioned, please format the description according
to
https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list....
You may want to elaborate a bit as well (what changes were made, why we're
making them, etc.)

[sunyunjia, 2016-09-08 14:12:15]

Description was changed from

==========
Implement Middle Click Autoscroll on all platforms not just Windows. This
feature is renamed from Pan Scrolling.

BUG=522011
==========

to

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling.

BUG=522011
==========

[sunyunjia, 2016-09-08 14:12:15]

sunyunjia@chromium.org changed reviewers:
+ isherman@chromium.org, tdresser@chromium.org

[sunyunjia, 2016-09-08 14:24:41]

Description was changed from

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling.

BUG=522011
==========

to

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011
==========

[sunyunjia, 2016-09-08 14:26:34]

On 2016/09/08 13:09:10, dtapuska wrote:
> On 2016/09/08 12:44:27, jochen wrote:
> > actually, please don't rename the use counter, that'll just confuse the UMA
> > dashboard. Either use a new one, or stick with the old name
> 
> the use counter was just added the other day. I think it is probably ok to
> rename no?

Hi Tim and Ilya,

Could you please take a look at this patch and see if we can rename the
usecounter from PanScrollingStart to MiddleClickAutoscrollStart? Thanks!

[tdresser, 2016-09-08 14:29:54]

On 2016/09/08 14:26:34, sunyunjia wrote:
> On 2016/09/08 13:09:10, dtapuska wrote:
> > On 2016/09/08 12:44:27, jochen wrote:
> > > actually, please don't rename the use counter, that'll just confuse the
UMA
> > > dashboard. Either use a new one, or stick with the old name
> > 
> > the use counter was just added the other day. I think it is probably ok to
> > rename no?
> 
> Hi Tim and Ilya,
> 
> Could you please take a look at this patch and see if we can rename the
> usecounter from PanScrollingStart to MiddleClickAutoscrollStart? Thanks!

I'll defer to Ilya. It's fine to just add a new use counter though.

[Ilya Sherman, 2016-09-08 19:51:06]

On 2016/09/08 14:29:54, tdresser wrote:
> On 2016/09/08 14:26:34, sunyunjia wrote:
> > On 2016/09/08 13:09:10, dtapuska wrote:
> > > On 2016/09/08 12:44:27, jochen wrote:
> > > > actually, please don't rename the use counter, that'll just confuse the
> UMA
> > > > dashboard. Either use a new one, or stick with the old name
> > > 
> > > the use counter was just added the other day. I think it is probably ok to
> > > rename no?
> > 
> > Hi Tim and Ilya,
> > 
> > Could you please take a look at this patch and see if we can rename the
> > usecounter from PanScrollingStart to MiddleClickAutoscrollStart? Thanks!
> 
> I'll defer to Ilya. It's fine to just add a new use counter though.

Agreed, it's probably simpler to just add a new counter.  However, if the
semantics of the new name are exactly the same as the semantics of the old name,
then it's okay to rename as well.  I kind of suspect that they aren't, though,
since you're keen to change the name in the first place =)

[tdresser, 2016-09-08 19:52:06]

On 2016/09/08 19:51:06, Ilya Sherman (Away Sep 9-20) wrote:
> On 2016/09/08 14:29:54, tdresser wrote:
> > On 2016/09/08 14:26:34, sunyunjia wrote:
> > > On 2016/09/08 13:09:10, dtapuska wrote:
> > > > On 2016/09/08 12:44:27, jochen wrote:
> > > > > actually, please don't rename the use counter, that'll just confuse
the
> > UMA
> > > > > dashboard. Either use a new one, or stick with the old name
> > > > 
> > > > the use counter was just added the other day. I think it is probably ok
to
> > > > rename no?
> > > 
> > > Hi Tim and Ilya,
> > > 
> > > Could you please take a look at this patch and see if we can rename the
> > > usecounter from PanScrollingStart to MiddleClickAutoscrollStart? Thanks!
> > 
> > I'll defer to Ilya. It's fine to just add a new use counter though.
> 
> Agreed, it's probably simpler to just add a new counter.  However, if the
> semantics of the new name are exactly the same as the semantics of the old
name,
> then it's okay to rename as well.  I kind of suspect that they aren't, though,
> since you're keen to change the name in the first place =)

We actually just changed the name we want to use for this feature, so a rename
would be fine.

[Ilya Sherman, 2016-09-08 19:54:57]

On 2016/09/08 19:52:06, tdresser wrote:
> On 2016/09/08 19:51:06, Ilya Sherman (Away Sep 9-20) wrote:
> > On 2016/09/08 14:29:54, tdresser wrote:
> > > On 2016/09/08 14:26:34, sunyunjia wrote:
> > > > On 2016/09/08 13:09:10, dtapuska wrote:
> > > > > On 2016/09/08 12:44:27, jochen wrote:
> > > > > > actually, please don't rename the use counter, that'll just confuse
> the
> > > UMA
> > > > > > dashboard. Either use a new one, or stick with the old name
> > > > > 
> > > > > the use counter was just added the other day. I think it is probably
ok
> to
> > > > > rename no?
> > > > 
> > > > Hi Tim and Ilya,
> > > > 
> > > > Could you please take a look at this patch and see if we can rename the
> > > > usecounter from PanScrollingStart to MiddleClickAutoscrollStart? Thanks!
> > > 
> > > I'll defer to Ilya. It's fine to just add a new use counter though.
> > 
> > Agreed, it's probably simpler to just add a new counter.  However, if the
> > semantics of the new name are exactly the same as the semantics of the old
> name,
> > then it's okay to rename as well.  I kind of suspect that they aren't,
though,
> > since you're keen to change the name in the first place =)
> 
> We actually just changed the name we want to use for this feature, so a rename
> would be fine.

Okay, histograms.xml lgtm in that case.

[sunyunjia, 2016-09-08 19:57:10]

The CQ bit was checked by sunyunjia@chromium.org

[sunyunjia, 2016-09-08 19:57:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2289213002/#ps260001
(title: "DCHECK and change the names more thoroughly")

[commit-bot: I haz the power, 2016-09-08 19:57:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 20:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 20:06:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sunyunjia, 2016-09-08 20:42:28]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 20:42:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-08 21:32:19]

The CQ bit was unchecked by sunyunjia@chromium.org

[sunyunjia, 2016-09-08 21:32:40]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:33:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 21:38:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:38:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sunyunjia, 2016-09-08 22:32:58]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 22:33:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:25:31]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-09 00:27:20]

The CQ bit was checked by sunyunjia@chromium.org

[sunyunjia, 2016-09-09 00:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
rbyers@chromium.org, bokan@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2289213002/#ps300001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into panscroll")

[commit-bot: I haz the power, 2016-09-09 00:29:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:38:38]

Description was changed from

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011
==========

to

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011
==========

[commit-bot: I haz the power, 2016-09-09 00:38:40]

Committed patchset #10 (id:300001)

[commit-bot: I haz the power, 2016-09-09 00:41:59]

Description was changed from

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011
==========

to

==========
Implement Middle Click Autoscroll on all platforms not just Windows. Previously
this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011

Committed: https://crrev.com/87f287bbe619d07e907dc00f48e2a6ad725367c1
Cr-Commit-Position: refs/heads/master@{#417454}
==========

[commit-bot: I haz the power, 2016-09-09 00:42:02]

Patchset 10 (id:??) landed as
https://crrev.com/87f287bbe619d07e907dc00f48e2a6ad725367c1
Cr-Commit-Position: refs/heads/master@{#417454}