Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2289193002: Add a #define to protect an upcoming Skia change. (Closed)

Created:
4 years, 3 months ago by Stephen White
Modified:
4 years, 3 months ago
Reviewers:
mtklein_C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a #define to protect an upcoming Skia change. BUG=642376 Committed: https://crrev.com/3c65d519f8f19505948edf5aed3714d440df040d Cr-Commit-Position: refs/heads/master@{#415380}

Patch Set 1 #

Patch Set 2 : Let's call it a renderer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Stephen White
PTAL. Thanks!
4 years, 3 months ago (2016-08-30 15:41:16 UTC) #3
mtklein_C
lgtm
4 years, 3 months ago (2016-08-30 16:06:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289193002/20001
4 years, 3 months ago (2016-08-30 18:54:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 18:59:52 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:01:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c65d519f8f19505948edf5aed3714d440df040d
Cr-Commit-Position: refs/heads/master@{#415380}

Powered by Google App Engine
This is Rietveld 408576698