Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2289183003: Add more appropriate assert_unreached to RTCPeerConnection-ice test (Closed)

Created:
4 years, 3 months ago by jeffcarp
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more appropriate assert_unreached to RTCPeerConnection-ice test BUG=614963 Committed: https://crrev.com/7e2ed59f295442d8ede52791b6c21a5a0225d96c Cr-Commit-Position: refs/heads/master@{#415429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jeffcarp
4 years, 3 months ago (2016-08-30 18:17:55 UTC) #2
qyearsley
lgtm
4 years, 3 months ago (2016-08-30 19:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289183003/1
4 years, 3 months ago (2016-08-30 19:54:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:21:16 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:23:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e2ed59f295442d8ede52791b6c21a5a0225d96c
Cr-Commit-Position: refs/heads/master@{#415429}

Powered by Google App Engine
This is Rietveld 408576698